[PSDK-86] Enable creation of wallets backed by server signers #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-stone
force-pushed
the
stone/PSDK-86-server-signer
branch
from
1b0dffa
to
321cf5e
Compare
alex-stone
force-pushed
the
stone/PSDK-86-server-signer
branch
from
321cf5e
to
deef84b
Compare
jazz-cb
reviewed
May 17, 2024
| create_wallet_request: { | ||
| wallet: { | ||
| network_id: network_id, | ||
| use_server_signer: server_signer |
There was a problem hiding this comment.
could you add this to the readme as well?
There was a problem hiding this comment.
Synced offline, we will update the readme once external developers are able to create and run server signers on their own.
There was a problem hiding this comment.
+1 to keeping it semi-hidden for now :)
jazz-cb
approved these changes
May 17, 2024
jazz-cb
approved these changes
May 17, 2024
yuga-cb
reviewed
May 17, 2024
| @@ -20,21 +20,11 @@ def id | |||
| end | |||
|
|
|||
| # Creates a new Wallet belonging to the User. | |||
| # @param network_id [String] (Optional) the ID of the blockchain network. Defaults to 'base-sepolia'. | |||
| # @param server_signer [Boolean] (Optional) whether Wallet should use project's server signer. Defaults to false. | |||
There was a problem hiding this comment.
Should we document saying this is a no-op right now?
There was a problem hiding this comment.
Moving to a feature branch!
This bumps the openapi ruby client to the latest openapi spec that allows for creating wallets with a server signer.
This enables creating a wallet with a server signer, e.g. `Coinbase::Wallet.create(server_signer: true)` This will create a new wallet using your projects default server signer.
alex-stone
force-pushed
the
stone/PSDK-86-server-signer
branch
from
6e9377a
to
1ce540b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This enables developers to create wallets that are backed by server signers v.s. managing the seeds themselves.
When calling
user.create_wallet(server_signer: true)the wallet will be created and associated with the project's default server signer (if one exists). It will return an error if a server signer does not exist for that project.Default address creation
Rather than add further cases to the wallet initialization this removes the side-effects from that method in favor of a
Wallet.createclass method.This code path will only be used for creation of wallets, where we will additionally create a default address for wallets that are not backed by server signers.
Network IDs
This also adds support for specifying the
network_idwhich the backend will properly validate based on supported networks.Qualified Impact
This touches the
user.create_walletflow