Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating wallet picker #1039

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Deprecating wallet picker #1039

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a8c5453
remove coinbase retail option
bangtoven Oct 26, 2023
5b593da
Revert "remove coinbase retail option"
bangtoven Oct 26, 2023
90c212c
Revert "Revert "remove coinbase retail option""
bangtoven Oct 27, 2023
4a02095
update icons
bangtoven Oct 27, 2023
599230a
revert appSrc stuff
bangtoven Nov 4, 2023
6e88ada
Merge branch 'master' into jungho/picker
bangtoven Nov 4, 2023
ed46aa0
cleanup
bangtoven Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 1 addition & 46 deletions packages/wallet-sdk/src/components/ConnectContent/ConnectContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ import { useCallback, useState } from 'preact/hooks';
import { createQrUrl } from '../../util';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before
Screenshot 2023-10-27 at 4 59 15 PM

after
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, we are working with design for new UI, removing the white space and making it responsive to screensize.

import { LIB_VERSION } from '../../version';
import { CloseIcon } from '../icons/CloseIcon';
import coinbaseRound from '../icons/coinbase-round-svg';
import coinbaseWalletRound from '../icons/coinbase-wallet-round-svg';
import { QRCodeIcon } from '../icons/QRCodeIcon';
import coinbaseLogo from '../icons/QRLogoCoinbase';
import walletLogo from '../icons/QRLogoWallet';
import { StatusDotIcon } from '../icons/StatusDotIcon';
import { QRCode } from '../QRCode';
import { Spinner } from '../Spinner/Spinner';
import { Theme } from '../types';
Expand All @@ -38,12 +36,6 @@ const wallets = {
icon: coinbaseWalletRound,
steps: CoinbaseWalletSteps,
},
'coinbase-app': {
title: 'Coinbase app',
description: 'Connect with your Coinbase account',
icon: coinbaseRound,
steps: CoinbaseAppSteps,
},
};

type WalletType = keyof typeof wallets;
Expand Down Expand Up @@ -84,14 +76,13 @@ export function ConnectContent(props: ConnectContentProps) {
return null;
}
const WalletSteps = wallet.steps;
const coinbaseApp = selected === 'coinbase-app';

return (
<div data-testid="connect-content" className={clsx('-cbwsdk-connect-content', theme)}>
<style>{css}</style>
<div className="-cbwsdk-connect-content-header">
<h2 className={clsx('-cbwsdk-connect-content-heading', theme)}>
Scan to connect with one of our mobile apps
Scan to connect with our mobile app
</h2>
{props.onCancel && (
<button type="button" className={'-cbwsdk-cancel-button'} onClick={props.onCancel}>
Expand All @@ -116,12 +107,6 @@ export function ConnectContent(props: ConnectContentProps) {
);
})}
</div>
{coinbaseApp && (
<div className={clsx('-cbwsdk-connect-content-update-app', theme)}>
Don’t see a <strong>Scan</strong> option? Update your Coinbase app to the latest
version and try again.
</div>
)}
</div>
<div className="-cbwsdk-connect-content-column-right">
<div className="-cbwsdk-connect-content-qr-wrapper">
Expand Down Expand Up @@ -211,33 +196,3 @@ export function CoinbaseWalletSteps({ theme }: WalletStepsProps) {
</ol>
);
}

export function CoinbaseAppSteps({ theme }: WalletStepsProps) {
return (
<ol className="-cbwsdk-wallet-steps">
<li className={clsx('-cbwsdk-wallet-steps-item', theme)}>
<div className="-cbwsdk-wallet-steps-item-wrapper">Open Coinbase app</div>
</li>
<li className={clsx('-cbwsdk-wallet-steps-item', theme)}>
<div className="-cbwsdk-wallet-steps-item-wrapper">
<span>
Tap <strong>More</strong>
</span>
<span
className={clsx('-cbwsdk-wallet-steps-pad-left', '-cbwsdk-wallet-steps-icon', theme)}
>
<StatusDotIcon fill={makeIconColor(theme)} />
</span>
<span className="-cbwsdk-wallet-steps-pad-left">
then <strong>Scan</strong>
</span>
<span
className={clsx('-cbwsdk-wallet-steps-pad-left', '-cbwsdk-wallet-steps-icon', theme)}
>
<QRCodeIcon fill={makeIconColor(theme)} />
</span>
</div>
</li>
</ol>
);
}
1 change: 0 additions & 1 deletion packages/wallet-sdk/src/components/Snackbar/Snackbar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ describe('Snackbar', () => {
test('@presentItem', async () => {
snackbar.presentItem({
message: 'Confirm on phone',
appSrc: 'coinbase-wallet',
menuItems: [
{
isRed: true,
Expand Down
15 changes: 2 additions & 13 deletions packages/wallet-sdk/src/components/Snackbar/Snackbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,9 @@ import { useEffect, useState } from 'preact/hooks';

import css from './Snackbar-css';

const cblogo = `data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMzIiIGhlaWdodD0iMzIiIGZpbGw9Im5vbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+PHBhdGggZD0iTTEuNDkyIDEwLjQxOWE4LjkzIDguOTMgMCAwMTguOTMtOC45M2gxMS4xNjNhOC45MyA4LjkzIDAgMDE4LjkzIDguOTN2MTEuMTYzYTguOTMgOC45MyAwIDAxLTguOTMgOC45M0gxMC40MjJhOC45MyA4LjkzIDAgMDEtOC45My04LjkzVjEwLjQxOXoiIGZpbGw9IiMxNjUyRjAiLz48cGF0aCBmaWxsLXJ1bGU9ImV2ZW5vZGQiIGNsaXAtcnVsZT0iZXZlbm9kZCIgZD0iTTEwLjQxOSAwSDIxLjU4QzI3LjMzNSAwIDMyIDQuNjY1IDMyIDEwLjQxOVYyMS41OEMzMiAyNy4zMzUgMjcuMzM1IDMyIDIxLjU4MSAzMkgxMC40MkM0LjY2NSAzMiAwIDI3LjMzNSAwIDIxLjU4MVYxMC40MkMwIDQuNjY1IDQuNjY1IDAgMTAuNDE5IDB6bTAgMS40ODhhOC45MyA4LjkzIDAgMDAtOC45MyA4LjkzdjExLjE2M2E4LjkzIDguOTMgMCAwMDguOTMgOC45M0gyMS41OGE4LjkzIDguOTMgMCAwMDguOTMtOC45M1YxMC40MmE4LjkzIDguOTMgMCAwMC04LjkzLTguOTNIMTAuNDJ6IiBmaWxsPSIjZmZmIi8+PHBhdGggZmlsbC1ydWxlPSJldmVub2RkIiBjbGlwLXJ1bGU9ImV2ZW5vZGQiIGQ9Ik0xNS45OTggMjYuMDQ5Yy01LjU0OSAwLTEwLjA0Ny00LjQ5OC0xMC4wNDctMTAuMDQ3IDAtNS41NDggNC40OTgtMTAuMDQ2IDEwLjA0Ny0xMC4wNDYgNS41NDggMCAxMC4wNDYgNC40OTggMTAuMDQ2IDEwLjA0NiAwIDUuNTQ5LTQuNDk4IDEwLjA0Ny0xMC4wNDYgMTAuMDQ3eiIgZmlsbD0iI2ZmZiIvPjxwYXRoIGQ9Ik0xMi43NjIgMTQuMjU0YzAtLjgyMi42NjctMS40ODkgMS40ODktMS40ODloMy40OTdjLjgyMiAwIDEuNDg4LjY2NiAxLjQ4OCAxLjQ4OXYzLjQ5N2MwIC44MjItLjY2NiAxLjQ4OC0xLjQ4OCAxLjQ4OGgtMy40OTdhMS40ODggMS40ODggMCAwMS0xLjQ4OS0xLjQ4OHYtMy40OTh6IiBmaWxsPSIjMTY1MkYwIi8+PC9zdmc+`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverting previous change b0c9041#diff-5963d849ba8821a176ba59be3d5c0ce674b78312019d36635730546fe81b296a

const gearIcon = `data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTIiIGhlaWdodD0iMTIiIGZpbGw9Im5vbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+PHBhdGggZD0iTTEyIDYuNzV2LTEuNWwtMS43Mi0uNTdjLS4wOC0uMjctLjE5LS41Mi0uMzItLjc3bC44MS0xLjYyLTEuMDYtMS4wNi0xLjYyLjgxYy0uMjQtLjEzLS41LS4yNC0uNzctLjMyTDYuNzUgMGgtMS41bC0uNTcgMS43MmMtLjI3LjA4LS41My4xOS0uNzcuMzJsLTEuNjItLjgxLTEuMDYgMS4wNi44MSAxLjYyYy0uMTMuMjQtLjI0LjUtLjMyLjc3TDAgNS4yNXYxLjVsMS43Mi41N2MuMDguMjcuMTkuNTMuMzIuNzdsLS44MSAxLjYyIDEuMDYgMS4wNiAxLjYyLS44MWMuMjQuMTMuNS4yMy43Ny4zMkw1LjI1IDEyaDEuNWwuNTctMS43MmMuMjctLjA4LjUyLS4xOS43Ny0uMzJsMS42Mi44MSAxLjA2LTEuMDYtLjgxLTEuNjJjLjEzLS4yNC4yMy0uNS4zMi0uNzdMMTIgNi43NXpNNiA4LjVhMi41IDIuNSAwIDAxMC01IDIuNSAyLjUgMCAwMTAgNXoiIGZpbGw9IiMwNTBGMTkiLz48L3N2Zz4=`;

function makeSnackbarIcon(appSrc?: string | null) {
switch (appSrc) {
case 'coinbase-app':
return `data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMzAiIGhlaWdodD0iMzAiIGZpbGw9Im5vbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+PHBhdGggZD0iTTE0LjY3NCAxOC44NThjLTIuMDQ1IDAtMy42NDgtMS43MjItMy42NDgtMy44NDVzMS42NTktMy44NDUgMy42NDgtMy44NDVjMS44MjQgMCAzLjMxNyAxLjM3NyAzLjU5MyAzLjIxNGgzLjcwM2MtLjMzMS0zLjk2LTMuNDgyLTcuMDU5LTcuMjk2LTcuMDU5LTQuMDM0IDAtNy4zNSAzLjQ0My03LjM1IDcuNjkgMCA0LjI0NiAzLjI2IDcuNjkgNy4zNSA3LjY5IDMuODcgMCA2Ljk2NS0zLjEgNy4yOTYtNy4wNTloLTMuNzAzYy0uMjc2IDEuODM2LTEuNzY5IDMuMjE0LTMuNTkzIDMuMjE0WiIgZmlsbD0iI2ZmZiIvPjxwYXRoIGQ9Ik0wIDEwLjY3OGMwLTMuNzExIDAtNS41OTYuNzQyLTcuMDIzQTYuNTMyIDYuNTMyIDAgMCAxIDMuNjU1Ljc0MkM1LjA4MiAwIDYuOTY3IDAgMTAuNjc4IDBoNy45MzhjMy43MTEgMCA1LjU5NiAwIDcuMDIzLjc0MmE2LjUzMSA2LjUzMSAwIDAgMSAyLjkxMyAyLjkxM2MuNzQyIDEuNDI3Ljc0MiAzLjMxMi43NDIgNy4wMjN2Ny45MzhjMCAzLjcxMSAwIDUuNTk2LS43NDIgNy4wMjNhNi41MzEgNi41MzEgMCAwIDEtMi45MTMgMi45MTNjLTEuNDI3Ljc0Mi0zLjMxMi43NDItNy4wMjMuNzQyaC03LjkzOGMtMy43MTEgMC01LjU5NiAwLTcuMDIzLS43NDJhNi41MzEgNi41MzEgMCAwIDEtMi45MTMtMi45MTNDMCAyNC4yMTIgMCAyMi4zODQgMCAxOC42MTZ2LTcuOTM4WiIgZmlsbD0iIzAwNTJGRiIvPjxwYXRoIGQ9Ik0xNC42ODQgMTkuNzczYy0yLjcyNyAwLTQuODY0LTIuMjk1LTQuODY0LTUuMTI2IDAtMi44MzEgMi4yMS01LjEyNyA0Ljg2NC01LjEyNyAyLjQzMiAwIDQuNDIyIDEuODM3IDQuNzkgNC4yODVoNC45MzhjLS40NDItNS4yOC00LjY0My05LjQxMS05LjcyOC05LjQxMS01LjM4IDAtOS44MDIgNC41OS05LjgwMiAxMC4yNTMgMCA1LjY2MiA0LjM0OCAxMC4yNTMgOS44MDIgMTAuMjUzIDUuMTU5IDAgOS4yODYtNC4xMzIgOS43MjgtOS40MTFoLTQuOTM4Yy0uMzY4IDIuNDQ4LTIuMzU4IDQuMjg0LTQuNzkgNC4yODRaIiBmaWxsPSIjZmZmIi8+PC9zdmc+`;
case 'coinbase-wallet-app':
default:
return `data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMzIiIGhlaWdodD0iMzIiIGZpbGw9Im5vbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+PHBhdGggZD0iTTEuNDkyIDEwLjQxOWE4LjkzIDguOTMgMCAwMTguOTMtOC45M2gxMS4xNjNhOC45MyA4LjkzIDAgMDE4LjkzIDguOTN2MTEuMTYzYTguOTMgOC45MyAwIDAxLTguOTMgOC45M0gxMC40MjJhOC45MyA4LjkzIDAgMDEtOC45My04LjkzVjEwLjQxOXoiIGZpbGw9IiMxNjUyRjAiLz48cGF0aCBmaWxsLXJ1bGU9ImV2ZW5vZGQiIGNsaXAtcnVsZT0iZXZlbm9kZCIgZD0iTTEwLjQxOSAwSDIxLjU4QzI3LjMzNSAwIDMyIDQuNjY1IDMyIDEwLjQxOVYyMS41OEMzMiAyNy4zMzUgMjcuMzM1IDMyIDIxLjU4MSAzMkgxMC40MkM0LjY2NSAzMiAwIDI3LjMzNSAwIDIxLjU4MVYxMC40MkMwIDQuNjY1IDQuNjY1IDAgMTAuNDE5IDB6bTAgMS40ODhhOC45MyA4LjkzIDAgMDAtOC45MyA4LjkzdjExLjE2M2E4LjkzIDguOTMgMCAwMDguOTMgOC45M0gyMS41OGE4LjkzIDguOTMgMCAwMDguOTMtOC45M1YxMC40MmE4LjkzIDguOTMgMCAwMC04LjkzLTguOTNIMTAuNDJ6IiBmaWxsPSIjZmZmIi8+PHBhdGggZmlsbC1ydWxlPSJldmVub2RkIiBjbGlwLXJ1bGU9ImV2ZW5vZGQiIGQ9Ik0xNS45OTggMjYuMDQ5Yy01LjU0OSAwLTEwLjA0Ny00LjQ5OC0xMC4wNDctMTAuMDQ3IDAtNS41NDggNC40OTgtMTAuMDQ2IDEwLjA0Ny0xMC4wNDYgNS41NDggMCAxMC4wNDYgNC40OTggMTAuMDQ2IDEwLjA0NiAwIDUuNTQ5LTQuNDk4IDEwLjA0Ny0xMC4wNDYgMTAuMDQ3eiIgZmlsbD0iI2ZmZiIvPjxwYXRoIGQ9Ik0xMi43NjIgMTQuMjU0YzAtLjgyMi42NjctMS40ODkgMS40ODktMS40ODloMy40OTdjLjgyMiAwIDEuNDg4LjY2NiAxLjQ4OCAxLjQ4OXYzLjQ5N2MwIC44MjItLjY2NiAxLjQ4OC0xLjQ4OCAxLjQ4OGgtMy40OTdhMS40ODggMS40ODggMCAwMS0xLjQ4OS0xLjQ4OHYtMy40OTh6IiBmaWxsPSIjMTY1MkYwIi8+PC9zdmc+`;
}
}

export interface SnackbarOptions {
darkMode: boolean;
}
Expand All @@ -27,7 +18,6 @@ export interface SnackbarInstanceProps {
message?: string;
menuItems?: SnackbarMenuItem[];
autoExpand?: boolean;
appSrc?: string | null;
}

export interface SnackbarMenuItem {
Expand Down Expand Up @@ -107,7 +97,6 @@ export const SnackbarInstance: FunctionComponent<SnackbarInstanceProps> = ({
autoExpand,
message,
menuItems,
appSrc,
}) => {
const [hidden, setHidden] = useState(true);
const [expanded, setExpanded] = useState(autoExpand ?? false);
Expand Down Expand Up @@ -140,7 +129,7 @@ export const SnackbarInstance: FunctionComponent<SnackbarInstanceProps> = ({
)}
>
<div class="-cbwsdk-snackbar-instance-header" onClick={toggleExpanded}>
<img src={makeSnackbarIcon(appSrc)} class="-cbwsdk-snackbar-instance-header-cblogo" />
<img src={cblogo} class="-cbwsdk-snackbar-instance-header-cblogo" />{' '}
<div class="-cbwsdk-snackbar-instance-header-message">{message}</div>
<div class="-gear-container">
{!expanded && (
Expand Down
15 changes: 5 additions & 10 deletions packages/wallet-sdk/src/components/icons/QRCodeIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,11 @@ import { h } from 'preact';

export function QRCodeIcon(props: h.JSX.SVGAttributes<SVGSVGElement>) {
return (
<svg width="10" height="10" viewBox="0 0 10 10" xmlns="http://www.w3.org/2000/svg" {...props}>
<path d="M8.2271 1.77124L7.0271 1.77124V2.97124H8.2271V1.77124Z" />
<path d="M5.44922 0.199219L5.44922 4.54922L9.79922 4.54922V0.199219L5.44922 0.199219ZM8.89922 3.64922L6.34922 3.64922L6.34922 1.09922L8.89922 1.09922V3.64922Z" />
<path d="M2.97124 1.77124L1.77124 1.77124L1.77124 2.97124H2.97124V1.77124Z" />
<path d="M0.199219 4.54922L4.54922 4.54922L4.54922 0.199219L0.199219 0.199219L0.199219 4.54922ZM1.09922 1.09922L3.64922 1.09922L3.64922 3.64922L1.09922 3.64922L1.09922 1.09922Z" />
<path d="M2.97124 7.0271H1.77124L1.77124 8.2271H2.97124V7.0271Z" />
<path d="M0.199219 9.79922H4.54922L4.54922 5.44922L0.199219 5.44922L0.199219 9.79922ZM1.09922 6.34922L3.64922 6.34922L3.64922 8.89922H1.09922L1.09922 6.34922Z" />
<path d="M8.89922 7.39912H7.99922V5.40112H5.44922L5.44922 9.79912H6.34922L6.34922 6.30112H7.09922V8.29912H9.79922V5.40112H8.89922V7.39912Z" />
<path d="M7.99912 8.89917H7.09912V9.79917H7.99912V8.89917Z" />
<path d="M9.79917 8.89917H8.89917V9.79917H9.79917V8.89917Z" />
<svg width="18" height="18" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg" {...props}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before
image

after
image

<path d="M3 3V8.99939L5 8.99996V5H9V3H3Z" />
<path d="M15 21L21 21V15.0006L19 15V19L15 19V21Z" />
<path d="M21 9H19V5H15.0006L15 3H21V9Z" />
<path d="M3 15V21H8.99939L8.99996 19H5L5 15H3Z" />
</svg>
);
}
13 changes: 0 additions & 13 deletions packages/wallet-sdk/src/components/icons/StatusDotIcon.tsx
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/wallet-sdk/src/components/icons/coinbase-round.svg
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions packages/wallet-sdk/src/components/icons/coinbase.svg
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/wallet-sdk/src/provider/MobileRelayUI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ export class MobileRelayUI implements WalletUI {

setStandalone?(_status: boolean) {} // no-op

setAppSrc(_src: string) {} // no-op

setConnectDisabled(_: boolean) {} // no-op

inlineAccountsResponse(): boolean {
Expand Down
2 changes: 0 additions & 2 deletions packages/wallet-sdk/src/provider/WalletLinkRelayUI.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ describe('WalletLinkRelayUI', () => {

expect(snackbarMock).toHaveBeenCalledWith({
message: 'Confirm on phone',
appSrc: null,
menuItems: [
{
isRed: true,
Expand Down Expand Up @@ -81,7 +80,6 @@ describe('WalletLinkRelayUI', () => {
expect(snackbarMock).toHaveBeenCalledWith({
autoExpand: true,
message: 'Connection lost',
appSrc: null,
menuItems: [
{
isRed: false,
Expand Down
8 changes: 0 additions & 8 deletions packages/wallet-sdk/src/provider/WalletLinkRelayUI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export class WalletLinkRelayUI implements WalletUI {
private readonly snackbar: Snackbar;
private standalone: boolean | null = null;
private attached = false;
private appSrc: string | null = null;

constructor(options: Readonly<WalletUIOptions>) {
this.snackbar = new Snackbar({
Expand Down Expand Up @@ -160,7 +159,6 @@ export class WalletLinkRelayUI implements WalletUI {
snackbarProps = {
autoExpand: true,
message: 'Connection lost',
appSrc: this.appSrc,
menuItems: [
{
isRed: false,
Expand All @@ -177,7 +175,6 @@ export class WalletLinkRelayUI implements WalletUI {
} else {
snackbarProps = {
message: 'Confirm on phone',
appSrc: this.appSrc,
menuItems: [
{
isRed: true,
Expand Down Expand Up @@ -206,11 +203,6 @@ export class WalletLinkRelayUI implements WalletUI {
return this.snackbar.presentItem(snackbarProps);
}

/* istanbul ignore next */
setAppSrc(appSrc: string): void {
this.appSrc = appSrc;
}

/* istanbul ignore next */
reloadUI(): void {
document.location.reload();
Expand Down
5 changes: 0 additions & 5 deletions packages/wallet-sdk/src/provider/WalletUI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,6 @@ export interface WalletUI {
*/
isStandalone(): boolean;

/**
* Set the UI's app src for different apps
*/
setAppSrc(src: string): void;

/**
* We want to disable showing the qr code for in-page connection if the dapp hasn't provided a json rpc url
*/
Expand Down
4 changes: 1 addition & 3 deletions packages/wallet-sdk/src/relay/MobileRelay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ export class MobileRelay extends WalletLinkRelay {
return {
promise: new Promise(() => {
const location = getLocation();
location.href = `https://www.coinbase.com/connect-dapp?uri=${encodeURIComponent(
location.href
)}`;
location.href = `https://go.cb-w.com/dapp?cb_url=${encodeURIComponent(location.href)}`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverting
image

dapp is also a correct path

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any walletlink changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. this is handled by branch.io

}),
cancel: () => {},
};
Expand Down
14 changes: 0 additions & 14 deletions packages/wallet-sdk/src/relay/WalletLinkRelay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,20 +281,6 @@ export class WalletLinkRelay extends WalletSDKRelayAbstract {
});
});
}

if (c.metadata.AppSrc !== undefined) {
aes256gcm
.decrypt(c.metadata.AppSrc!, session.secret)
.then((appSrc) => {
this.ui.setAppSrc(appSrc);
})
.catch(() => {
this.diagnostic?.log(EVENTS.GENERAL_ERROR, {
message: 'Had error decrypting',
value: 'appSrc',
});
});
}
});

const ui = this.options.uiConstructor({
Expand Down
Loading