Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up push notifications #6

Closed
wants to merge 1 commit into from
Closed

Conversation

AndrewGold
Copy link
Contributor

Send a push notification to the session's webhook URL with the session's webhook ID when an event is published to a guest

@@ -204,7 +211,7 @@ func TestRPC(t *testing.T) {
"id": float64(hostReqID),
"sessionId": sessionID,
"webhookId": "1234abcd",
"webhookUrl": "https://example.com/",
"webhookUrl": webhookURL,
"metadata": map[string]interface{}{
"foo": "hello world",
"bar": "1234",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to test that webhook url is called with correct params

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the expectations to the test

Sent bool `json:"sent"`
}

type sendParams struct {
EventID string `json:"eventID"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow the json convention used in other structs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume by this you mean:
eventID->eventId
webhookID->webhookId

Done

@AndrewGold
Copy link
Contributor Author

I realized sessionId is also needed by the client in order to retrieve the request details, so I modified the PR to include sessionId in the notification payload as well

@AndrewGold AndrewGold force-pushed the drew/hook-up-push branch 2 times, most recently from 84b656d to 9be3394 Compare May 30, 2019 21:31
@AndrewGold AndrewGold force-pushed the drew/hook-up-push branch 2 times, most recently from fd2c00f to edb05d8 Compare June 6, 2019 22:44
if err != nil {
return errors.Wrap(err, "failed to send push notification request")
}

defer res.Body.Close()

response := sendResponse{}
response := SendResponse{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of unmarshalling, let's just check for status code 200

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that, but I'm pretty sure the server will still return 200 even if there's an error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's because we are doing rpc style endpoints but i feel like most other people wouldn't.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we pretty much fire and forget, (errors are not handled) the fact that our backend behaves weirdly shouldn't matter

func NewAPI(serverURL string, secret string) *API {
return &API{serverURL: serverURL, secret: secret}
func NewAPI(rpcURL string) *API {
return &API{rpcURL: rpcURL}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we now have some regular web endpoints (e.g. get events), so we should change this to serverURL and have it contain root URL instead of the websocket RPC URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

webhookID = "1234"
eventID = "5678"
sessionID = "abcd"
rpcURL = "ws:example.com/rpc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serverURL = "https://example.com"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}

j, err := json.Marshal(notification)
if err != nil {
return errors.Wrap(err, "unable to marshal notification")
}

res, err := http.Post(a.serverURL, "application/json", bytes.NewBuffer(j))
res, err := http.Post(webhookURL, "application/json", bytes.NewBuffer(j))
Copy link
Contributor

@petejkim petejkim Jun 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangism: try using json.NewEncoder with io.Pipe so it can directly stream json to http request, instead of keeping the json in memory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -12,38 +12,36 @@ import (

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to webhook/webhook.go ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@@ -327,6 +337,17 @@ func (c *MessageHandler) findAuthedSessionWithID(
return session, nil
}

func (c *MessageHandler) sendPush(eventID, sessionID, webhookID, webhookURL string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callWebhook?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AndrewGold AndrewGold force-pushed the drew/hook-up-push branch 4 times, most recently from ab1a6dc to 7479c8a Compare June 11, 2019 18:41
@@ -261,7 +266,8 @@ func (c *MessageHandler) handlePublishEvent(
return newServerMessageFail(msg.ID, msg.SessionID, "invalid event name")
}

if !c.authedSessions.Contains(msg.SessionID) {
session, err := c.findAuthedSessionWithID(msg.SessionID)
if err != nil {
errMsg := fmt.Sprintf("not authenticated to session: %s", msg.SessionID)
return newServerMessageFail(msg.ID, msg.SessionID, errMsg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use err, look at other uses of findAuthedSessionWithID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

webhookURL = "https://example.com"
webhookID = "1234abcd"
host = "example.com"
rpcURL = "ws:example.com/rpc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serverURL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed

webhookID = "1234"
eventID = "5678"
sessionID = "abcd"
rpcURL = "https://example.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serverURL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@AndrewGold AndrewGold force-pushed the drew/hook-up-push branch 3 times, most recently from f08f71c to 018381c Compare June 11, 2019 21:58
@petejkim petejkim closed this Jun 11, 2019
@petejkim petejkim reopened this Jun 11, 2019
@AndrewGold AndrewGold closed this Jun 11, 2019
@AndrewGold AndrewGold deleted the drew/hook-up-push branch June 11, 2019 22:02
hieronymus777 pushed a commit that referenced this pull request Nov 18, 2021
Require one review for commits
bangtoven added a commit that referenced this pull request Feb 29, 2024
commit b57482fc651d8441ee942192d0238d34637823cb
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Dec 8 15:18:29 2023 -0500

    use 3.9.1 on the test app (#1097)

commit c7cd33e0c1a0a98f6b81119f29af6d7fce43d445
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Dec 8 11:54:28 2023 -0800

    v3.9.1 (#1095)

    Co-authored-by: bangtoven <bangtoven@users.noreply.github.com>

commit d898a4d5da19a1c9f21e66b9eeb0caa088ebf9b6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Dec 8 11:53:25 2023 -0800

    Bump @adobe/css-tools from 4.3.1 to 4.3.2 (#1088)

    Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2.
    - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
    - [Commits](https://github.com/adobe/css-tools/commits)

    ---
    updated-dependencies:
    - dependency-name: "@adobe/css-tools"
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit e33a7414ec2b759ead01cb1432cf351640c642e1
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Dec 8 14:52:47 2023 -0500

    Clean up SVG files (#1096)

    * remove copyright

    * optimize icon importing

    * no svg -> ts conversion

    * remove unnecessary logo file

commit 92eba409d1ecc4a6150f8ca93d541ee44218d86c
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Dec 8 12:31:18 2023 -0500

    Optimize compile-assets.js (#1094)

    * remove copyright

    * optimize compile asset

commit 11a44ba2f7e85be8299f202f6189d4965599683e
Author: Felix Zhang <22125939+fan-zhang-sv@users.noreply.github.com>
Date:   Fri Dec 1 21:52:40 2023 -0800

    use 3.9.0 (#1089)

commit f5f1151e06904d436345554685bd634524089bae
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Nov 24 11:14:38 2023 -0800

    v3.9.0 (#1085)

    Co-authored-by: fan-zhang-sv <fan-zhang-sv@users.noreply.github.com>

commit 6eada1eb870956b92d22f0ab832d6e4bfd803395
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Nov 24 14:14:07 2023 -0500

    Move eth-sig-util dependency into testapp (#1082)

commit 33482564f038b7fea72ddaabeba617d094c81de2
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Nov 21 16:54:56 2023 -0800

    v3.9.0-canary.6 (#1080)

    Co-authored-by: fan-zhang-sv <fan-zhang-sv@users.noreply.github.com>

commit d962bdb142d292cedf4bf087fdff0b413da55837
Author: Felix Zhang <22125939+fan-zhang-sv@users.noreply.github.com>
Date:   Tue Nov 21 16:36:39 2023 -0800

    Misc update (#1079)

    * web3Methods

    * childRequestEthereumAccounts

    * save sdk version in localstorage

commit 8d6c32c72f945e04e4cc71ef423df9e2348db8ea
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 18:32:03 2023 -0500

    Define codeflow job (#1075)

    * define codeflow job

    commit 74d75fdcf3f891cbe55403efb1136fed5c89947f
    Merge: 53cedd28 e5b80fb3
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 14:18:56 2023 -0800

        Merge pull request #4 from wallet/jungho/asdfasdfasdf

        shared

    commit e5b80fb308e7176fcf8cc4a297e477cb5521184a
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 14:15:45 2023 -0800

        shared

    commit 53cedd285560a2ed2e74ed173aaa9b1b3301e0ae
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 14:05:36 2023 -0800

        fix (#3)

        * no slack error

        * config file

        * ugh

    commit 864ddc9d3b23f2ae3435226c6357c459e9331e42
    Merge: a9f34b3d 85813135
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 13:18:44 2023 -0800

        Merge pull request #2 from wallet/jungho/codeflow-build

        ls

    commit 85813135cdba5d477f03fac3acc7cf521dcf2b06
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 13:17:39 2023 -0800

        sadfasdfadf

    commit dbaea5013c4e1d8a1f0b3ec29c97e32ff21b8b1a
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 13:17:20 2023 -0800

        asdfasdf

    commit 384ab2e54a04d2b33c94aea3558342b8e59f18af
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 13:02:45 2023 -0800

        WORKDIR /sdk

    commit 64dc76525124ddba8ad714965861b54ffc990996
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:58:12 2023 -0800

        workdir /sdk

    commit 70dd5982f4f7fc4a7dc813355c2d4eb61b57b8a7
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:57:46 2023 -0800

        udpate copy path

    commit 3d686cf8335f40e200b138fc0666f2d7bbc689ad
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:48:38 2023 -0800

        ls

    commit a9f34b3d833e7236697ff40229d32590c041a506
    Merge: 21788de f2e819b7
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:40:59 2023 -0800

        Merge pull request #1 from wallet/jungho/codeflow

        codeflow

    commit f2e819b73cb68b9ef9909dd5835845fb2a4a314e
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:32:41 2023 -0800

        cbhq

    commit a9116b3dc0afb2ecb6fd322032dca591c0c63ba9
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:29:08 2023 -0800

        rename it as cbhq/wallet-sdk

    commit 74ccade
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:13:24 2023 -0800

        update version only

    commit 58a325c
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:06:08 2023 -0800

        run on the wallet-sdk dir

    commit d335560
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:54:43 2023 -0800

        update name as well

    commit 529c0a2
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:46:52 2023 -0800

        cleanup

    commit bdac83c
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:41:13 2023 -0800

        update release.sh to take `canary`

        # Conflicts:
        #	scripts/release.sh

    commit 3ec1110
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:17:42 2023 -0800

        cleanup

    commit 091bcb5
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:06:05 2023 -0800

        add canary option to release.sh

    commit 5c74bd5
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 10:40:49 2023 -0800

        cleanup

    commit 6269c0c
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Fri Nov 17 15:28:25 2023 -0800

        codeflow job (#2)

        Update README.md

        update dockerfile

        autobuild: true

        WORKDIR /packages/wallet-sdk

        COPY . .

        asdfasdfasdfadfsa

        asdfafwa qwerR2DCewae XC

        tsconfig

        module

        NodeNext

        tsconfig

        path

        SVG issue

        publish?

        asdfsd a

        WORKDIR /

        이거일듯 시발

    * hmmm

    * no slack channel stuff

commit 94dc46c1c7a8e268368bed9c9bc2c7c9eac3a2d3
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Dec 20 13:04:45 2023 -0800

    some updates (#9)

    * enable SCW by default (#7)

    * pass app name

commit d6ce8229c58a0550d2193190895d8c7145265630
Merge: a9e83d9e 0741d9b2
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Tue Nov 21 11:08:47 2023 -0800

    Merge pull request #6 from wilson-cusack/wilson/fix-send-request

    fix connecting and sending request

commit 0741d9b209f81a282db0ea48e37d679b163d749a
Author: Wilson Cusack <wilson.cusack@coinbase.com>
Date:   Tue Nov 21 12:41:13 2023 -0600

    fix connecting and sending request

commit a9e83d9e499dd49773cc67ec1e7045e87ee5b181
Merge: 74d75fdc 66c274aa
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 17:10:45 2023 -0800

    Merge pull request #5 from wallet/jungho/apply-scw-stuff

    Groundwork for SCW support

commit 66c274aa4b6235e9a9c3f0b715e1abeeb856d62f
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 17:08:20 2023 -0800

    cleanup

commit cec705f029c021f5f4f7904200af585f6891c2f4
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:50:10 2023 -0800

    update test app

commit 55405690c64664482479cf0da6c69bb462cd6a75
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:45:29 2023 -0800

    comment

commit 40ba12f1794ec93cfce3b0160e91da99dac032fd
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:43:15 2023 -0800

    enable chameleon by default. option to make it exclusive.

commit 806895f2db5af426438e52b17ed5bb836dac74d8
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:22:40 2023 -0800

    reset test app

commit 50e4e6f535107e4cf10384ba5c94ea1fc70c0cf5
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:21:06 2023 -0800

    update

commit c9fc7c6cdd17454524ed4ae59de971a676780e29
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 15:39:11 2023 -0800

    path

commit bdd7f69b9c80c8cb6bfb1fb9a8ba1a8efb143771
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Nov 16 11:47:59 2023 -0800

    scw WIP

    ui stuff?

    SCWRelay

    don’t lose it

    tlqkf

    ok

    sendRequest

    hide extension upsell if props.enableSignInWithCoinbase

    enableMobileWalletLink

commit 74d75fdcf3f891cbe55403efb1136fed5c89947f
Merge: 53cedd28 e5b80fb3
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 14:18:56 2023 -0800

    Merge pull request #4 from wallet/jungho/asdfasdfasdf

    shared

commit e5b80fb308e7176fcf8cc4a297e477cb5521184a
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 14:15:45 2023 -0800

    shared

commit 53cedd285560a2ed2e74ed173aaa9b1b3301e0ae
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 14:05:36 2023 -0800

    fix (#3)

    * no slack error

    * config file

    * ugh

commit 864ddc9d3b23f2ae3435226c6357c459e9331e42
Merge: a9f34b3d 85813135
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 13:18:44 2023 -0800

    Merge pull request #2 from wallet/jungho/codeflow-build

    ls

commit 85813135cdba5d477f03fac3acc7cf521dcf2b06
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 13:17:39 2023 -0800

    sadfasdfadf

commit dbaea5013c4e1d8a1f0b3ec29c97e32ff21b8b1a
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 13:17:20 2023 -0800

    asdfasdf

commit 384ab2e54a04d2b33c94aea3558342b8e59f18af
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 13:02:45 2023 -0800

    WORKDIR /sdk

commit 64dc76525124ddba8ad714965861b54ffc990996
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:58:12 2023 -0800

    workdir /sdk

commit 70dd5982f4f7fc4a7dc813355c2d4eb61b57b8a7
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:57:46 2023 -0800

    udpate copy path

commit 3d686cf8335f40e200b138fc0666f2d7bbc689ad
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:48:38 2023 -0800

    ls

commit a9f34b3d833e7236697ff40229d32590c041a506
Merge: 21788de f2e819b7
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:40:59 2023 -0800

    Merge pull request #1 from wallet/jungho/codeflow

    codeflow

commit f2e819b73cb68b9ef9909dd5835845fb2a4a314e
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:32:41 2023 -0800

    cbhq

commit a9116b3dc0afb2ecb6fd322032dca591c0c63ba9
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:29:08 2023 -0800

    rename it as cbhq/wallet-sdk

commit 74ccade
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:13:24 2023 -0800

    update version only

commit 58a325c
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:06:08 2023 -0800

    run on the wallet-sdk dir

commit d335560
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:54:43 2023 -0800

    update name as well

commit 529c0a2
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:46:52 2023 -0800

    cleanup

commit bdac83c
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:41:13 2023 -0800

    update release.sh to take `canary`

    # Conflicts:
    #	scripts/release.sh

commit 3ec1110
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:17:42 2023 -0800

    cleanup

commit 091bcb5
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:06:05 2023 -0800

    add canary option to release.sh

commit 5c74bd5
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 10:40:49 2023 -0800

    cleanup

commit 6269c0c
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Nov 17 15:28:25 2023 -0800

    codeflow job (#2)

    Update README.md

    update dockerfile

    autobuild: true

    WORKDIR /packages/wallet-sdk

    COPY . .

    asdfasdfasdfadfsa

    asdfafwa qwerR2DCewae XC

    tsconfig

    module

    NodeNext

    tsconfig

    path

    SVG issue

    publish?

    asdfsd a

    WORKDIR /

    이거일듯 시발
bangtoven pushed a commit that referenced this pull request Feb 29, 2024
* SCWClient

* PopUpCommunicator

* test

* { once: true }

* request-response mapping

* todo

* switch to requestResolutions map

* Types
bangtoven added a commit that referenced this pull request Feb 29, 2024
commit b57482fc651d8441ee942192d0238d34637823cb
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Dec 8 15:18:29 2023 -0500

    use 3.9.1 on the test app (#1097)

commit c7cd33e0c1a0a98f6b81119f29af6d7fce43d445
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Dec 8 11:54:28 2023 -0800

    v3.9.1 (#1095)

    Co-authored-by: bangtoven <bangtoven@users.noreply.github.com>

commit d898a4d5da19a1c9f21e66b9eeb0caa088ebf9b6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Dec 8 11:53:25 2023 -0800

    Bump @adobe/css-tools from 4.3.1 to 4.3.2 (#1088)

    Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2.
    - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
    - [Commits](https://github.com/adobe/css-tools/commits)

    ---
    updated-dependencies:
    - dependency-name: "@adobe/css-tools"
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit e33a7414ec2b759ead01cb1432cf351640c642e1
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Dec 8 14:52:47 2023 -0500

    Clean up SVG files (#1096)

    * remove copyright

    * optimize icon importing

    * no svg -> ts conversion

    * remove unnecessary logo file

commit 92eba409d1ecc4a6150f8ca93d541ee44218d86c
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Dec 8 12:31:18 2023 -0500

    Optimize compile-assets.js (#1094)

    * remove copyright

    * optimize compile asset

commit 11a44ba2f7e85be8299f202f6189d4965599683e
Author: Felix Zhang <22125939+fan-zhang-sv@users.noreply.github.com>
Date:   Fri Dec 1 21:52:40 2023 -0800

    use 3.9.0 (#1089)

commit f5f1151e06904d436345554685bd634524089bae
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Nov 24 11:14:38 2023 -0800

    v3.9.0 (#1085)

    Co-authored-by: fan-zhang-sv <fan-zhang-sv@users.noreply.github.com>

commit 6eada1eb870956b92d22f0ab832d6e4bfd803395
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Nov 24 14:14:07 2023 -0500

    Move eth-sig-util dependency into testapp (#1082)

commit 33482564f038b7fea72ddaabeba617d094c81de2
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Nov 21 16:54:56 2023 -0800

    v3.9.0-canary.6 (#1080)

    Co-authored-by: fan-zhang-sv <fan-zhang-sv@users.noreply.github.com>

commit d962bdb142d292cedf4bf087fdff0b413da55837
Author: Felix Zhang <22125939+fan-zhang-sv@users.noreply.github.com>
Date:   Tue Nov 21 16:36:39 2023 -0800

    Misc update (#1079)

    * web3Methods

    * childRequestEthereumAccounts

    * save sdk version in localstorage

commit 8d6c32c72f945e04e4cc71ef423df9e2348db8ea
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 18:32:03 2023 -0500

    Define codeflow job (#1075)

    * define codeflow job

    commit 74d75fdcf3f891cbe55403efb1136fed5c89947f
    Merge: 53cedd28 e5b80fb3
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 14:18:56 2023 -0800

        Merge pull request #4 from wallet/jungho/asdfasdfasdf

        shared

    commit e5b80fb308e7176fcf8cc4a297e477cb5521184a
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 14:15:45 2023 -0800

        shared

    commit 53cedd285560a2ed2e74ed173aaa9b1b3301e0ae
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 14:05:36 2023 -0800

        fix (#3)

        * no slack error

        * config file

        * ugh

    commit 864ddc9d3b23f2ae3435226c6357c459e9331e42
    Merge: a9f34b3d 85813135
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 13:18:44 2023 -0800

        Merge pull request #2 from wallet/jungho/codeflow-build

        ls

    commit 85813135cdba5d477f03fac3acc7cf521dcf2b06
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 13:17:39 2023 -0800

        sadfasdfadf

    commit dbaea5013c4e1d8a1f0b3ec29c97e32ff21b8b1a
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 13:17:20 2023 -0800

        asdfasdf

    commit 384ab2e54a04d2b33c94aea3558342b8e59f18af
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 13:02:45 2023 -0800

        WORKDIR /sdk

    commit 64dc76525124ddba8ad714965861b54ffc990996
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:58:12 2023 -0800

        workdir /sdk

    commit 70dd5982f4f7fc4a7dc813355c2d4eb61b57b8a7
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:57:46 2023 -0800

        udpate copy path

    commit 3d686cf8335f40e200b138fc0666f2d7bbc689ad
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:48:38 2023 -0800

        ls

    commit a9f34b3d833e7236697ff40229d32590c041a506
    Merge: 21788de f2e819b7
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:40:59 2023 -0800

        Merge pull request #1 from wallet/jungho/codeflow

        codeflow

    commit f2e819b73cb68b9ef9909dd5835845fb2a4a314e
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:32:41 2023 -0800

        cbhq

    commit a9116b3dc0afb2ecb6fd322032dca591c0c63ba9
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:29:08 2023 -0800

        rename it as cbhq/wallet-sdk

    commit 74ccade
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:13:24 2023 -0800

        update version only

    commit 58a325c
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 12:06:08 2023 -0800

        run on the wallet-sdk dir

    commit d335560
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:54:43 2023 -0800

        update name as well

    commit 529c0a2
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:46:52 2023 -0800

        cleanup

    commit bdac83c
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:41:13 2023 -0800

        update release.sh to take `canary`

        # Conflicts:
        #	scripts/release.sh

    commit 3ec1110
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:17:42 2023 -0800

        cleanup

    commit 091bcb5
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 11:06:05 2023 -0800

        add canary option to release.sh

    commit 5c74bd5
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Mon Nov 20 10:40:49 2023 -0800

        cleanup

    commit 6269c0c
    Author: Jungho Bang <jungho.bang@coinbase.com>
    Date:   Fri Nov 17 15:28:25 2023 -0800

        codeflow job (#2)

        Update README.md

        update dockerfile

        autobuild: true

        WORKDIR /packages/wallet-sdk

        COPY . .

        asdfasdfasdfadfsa

        asdfafwa qwerR2DCewae XC

        tsconfig

        module

        NodeNext

        tsconfig

        path

        SVG issue

        publish?

        asdfsd a

        WORKDIR /

        이거일듯 시발

    * hmmm

    * no slack channel stuff

commit 94dc46c1c7a8e268368bed9c9bc2c7c9eac3a2d3
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Dec 20 13:04:45 2023 -0800

    some updates (#9)

    * enable SCW by default (#7)

    * pass app name

commit d6ce8229c58a0550d2193190895d8c7145265630
Merge: a9e83d9e 0741d9b2
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Tue Nov 21 11:08:47 2023 -0800

    Merge pull request #6 from wilson-cusack/wilson/fix-send-request

    fix connecting and sending request

commit 0741d9b209f81a282db0ea48e37d679b163d749a
Author: Wilson Cusack <wilson.cusack@coinbase.com>
Date:   Tue Nov 21 12:41:13 2023 -0600

    fix connecting and sending request

commit a9e83d9e499dd49773cc67ec1e7045e87ee5b181
Merge: 74d75fdc 66c274aa
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 17:10:45 2023 -0800

    Merge pull request #5 from wallet/jungho/apply-scw-stuff

    Groundwork for SCW support

commit 66c274aa4b6235e9a9c3f0b715e1abeeb856d62f
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 17:08:20 2023 -0800

    cleanup

commit cec705f029c021f5f4f7904200af585f6891c2f4
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:50:10 2023 -0800

    update test app

commit 55405690c64664482479cf0da6c69bb462cd6a75
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:45:29 2023 -0800

    comment

commit 40ba12f1794ec93cfce3b0160e91da99dac032fd
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:43:15 2023 -0800

    enable chameleon by default. option to make it exclusive.

commit 806895f2db5af426438e52b17ed5bb836dac74d8
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:22:40 2023 -0800

    reset test app

commit 50e4e6f535107e4cf10384ba5c94ea1fc70c0cf5
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 16:21:06 2023 -0800

    update

commit c9fc7c6cdd17454524ed4ae59de971a676780e29
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 15:39:11 2023 -0800

    path

commit bdd7f69b9c80c8cb6bfb1fb9a8ba1a8efb143771
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Nov 16 11:47:59 2023 -0800

    scw WIP

    ui stuff?

    SCWRelay

    don’t lose it

    tlqkf

    ok

    sendRequest

    hide extension upsell if props.enableSignInWithCoinbase

    enableMobileWalletLink

commit 74d75fdcf3f891cbe55403efb1136fed5c89947f
Merge: 53cedd28 e5b80fb3
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 14:18:56 2023 -0800

    Merge pull request #4 from wallet/jungho/asdfasdfasdf

    shared

commit e5b80fb308e7176fcf8cc4a297e477cb5521184a
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 14:15:45 2023 -0800

    shared

commit 53cedd285560a2ed2e74ed173aaa9b1b3301e0ae
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 14:05:36 2023 -0800

    fix (#3)

    * no slack error

    * config file

    * ugh

commit 864ddc9d3b23f2ae3435226c6357c459e9331e42
Merge: a9f34b3d 85813135
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 13:18:44 2023 -0800

    Merge pull request #2 from wallet/jungho/codeflow-build

    ls

commit 85813135cdba5d477f03fac3acc7cf521dcf2b06
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 13:17:39 2023 -0800

    sadfasdfadf

commit dbaea5013c4e1d8a1f0b3ec29c97e32ff21b8b1a
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 13:17:20 2023 -0800

    asdfasdf

commit 384ab2e54a04d2b33c94aea3558342b8e59f18af
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 13:02:45 2023 -0800

    WORKDIR /sdk

commit 64dc76525124ddba8ad714965861b54ffc990996
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:58:12 2023 -0800

    workdir /sdk

commit 70dd5982f4f7fc4a7dc813355c2d4eb61b57b8a7
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:57:46 2023 -0800

    udpate copy path

commit 3d686cf8335f40e200b138fc0666f2d7bbc689ad
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:48:38 2023 -0800

    ls

commit a9f34b3d833e7236697ff40229d32590c041a506
Merge: 21788de f2e819b7
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:40:59 2023 -0800

    Merge pull request #1 from wallet/jungho/codeflow

    codeflow

commit f2e819b73cb68b9ef9909dd5835845fb2a4a314e
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:32:41 2023 -0800

    cbhq

commit a9116b3dc0afb2ecb6fd322032dca591c0c63ba9
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:29:08 2023 -0800

    rename it as cbhq/wallet-sdk

commit 74ccade
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:13:24 2023 -0800

    update version only

commit 58a325c
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 12:06:08 2023 -0800

    run on the wallet-sdk dir

commit d335560
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:54:43 2023 -0800

    update name as well

commit 529c0a2
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:46:52 2023 -0800

    cleanup

commit bdac83c
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:41:13 2023 -0800

    update release.sh to take `canary`

    # Conflicts:
    #	scripts/release.sh

commit 3ec1110
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:17:42 2023 -0800

    cleanup

commit 091bcb5
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 11:06:05 2023 -0800

    add canary option to release.sh

commit 5c74bd5
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Mon Nov 20 10:40:49 2023 -0800

    cleanup

commit 6269c0c
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri Nov 17 15:28:25 2023 -0800

    codeflow job (#2)

    Update README.md

    update dockerfile

    autobuild: true

    WORKDIR /packages/wallet-sdk

    COPY . .

    asdfasdfasdfadfsa

    asdfafwa qwerR2DCewae XC

    tsconfig

    module

    NodeNext

    tsconfig

    path

    SVG issue

    publish?

    asdfsd a

    WORKDIR /

    이거일듯 시발
bangtoven pushed a commit that referenced this pull request Feb 29, 2024
* SCWClient

* PopUpCommunicator

* test

* { once: true }

* request-response mapping

* todo

* switch to requestResolutions map

* Types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants