Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client] Handle 408 Status Code as Retriable #263

Merged
merged 2 commits into from
Dec 4, 2020
Merged

[client] Handle 408 Status Code as Retriable #263

merged 2 commits into from
Dec 4, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Dec 4, 2020 •
edited
Loading

This PR updates client to treat a 408 as ErrRetriable.

Changes

  • update templates
  • run make gen

@patrick-ogrady patrick-ogrady changed the title [fetcher] Handle 408 Status Code as Retriable [client] Handle 408 Status Code as Retriable Dec 4, 2020
@patrick-ogrady patrick-ogrady merged commit f471414 into master Dec 4, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/408-transient branch December 4, 2020 16:10
@patrick-ogrady patrick-ogrady mentioned this pull request Dec 7, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiwu7 qiwu7 qiwu7 approved these changes

@brockmiller brockmiller Awaiting requested review from brockmiller

@alex-stone alex-stone Awaiting requested review from alex-stone

@septerr septerr Awaiting requested review from septerr

@yfl92 yfl92 Awaiting requested review from yfl92

@arjun-io arjun-io Awaiting requested review from arjun-io

@cindyxkuang cindyxkuang Awaiting requested review from cindyxkuang

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick-ogrady @qiwu7