Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support v1.4.0 Spec Update #55

Merged
merged 21 commits into from
Jun 28, 2020
Merged

Support v1.4.0 Spec Update #55

merged 21 commits into from
Jun 28, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jun 26, 2020 •
edited
Loading

Changes

  • Add support for v1.4.0 of the specification (with support for the new Construction API)
  • Update examples
  • Automatically reject historical balance queries if not supported
  • Update asserter/request.go

Future PR

niallo
niallo previously approved these changes Jun 26, 2020
View reviewed changes
@coveralls
Copy link

coveralls commented Jun 27, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2019

  • 180 of 205 (87.8%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 68.206%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fetcher/mempool.go 0 1 0.0%
asserter/asserter.go 4 6 66.67%
asserter/block.go 22 26 84.62%
asserter/construction.go 65 71 91.55%
asserter/request.go 89 101 88.12%
Totals Coverage Status
Change from base Build 1821: 1.5%
Covered Lines: 1639
Relevant Lines: 2403
💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title Support v1.4.0 Spec Update [WIP] Support v1.4.0 Spec Update Jun 27, 2020
@patrick-ogrady patrick-ogrady mentioned this pull request Jun 27, 2020
Closed
@patrick-ogrady patrick-ogrady changed the title [WIP] Support v1.4.0 Spec Update [WIP] Support v1.4.0 Spec Jun 27, 2020
@patrick-ogrady patrick-ogrady changed the title [WIP] Support v1.4.0 Spec Support v1.4.0 Spec Update Jun 27, 2020
@patrick-ogrady patrick-ogrady mentioned this pull request Jun 27, 2020
Merged
@patrick-ogrady patrick-ogrady requested review from niallo, juliankoh, zquestz and a team June 27, 2020 21:54
@patrick-ogrady patrick-ogrady merged commit b9ec88d into master Jun 28, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/update-spec-v1-4-0 branch June 28, 2020 06:58
@patrick-ogrady patrick-ogrady mentioned this pull request Jun 30, 2020
Merged
@patrick-ogrady patrick-ogrady mentioned this pull request Jul 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zquestz zquestz zquestz approved these changes

@niallo niallo Awaiting requested review from niallo

@juliankoh juliankoh Awaiting requested review from juliankoh

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrick-ogrady @coveralls @zquestz @niallo