Upgrade MongoDB driver version to v1.14.0 #69
Conversation
| @@ -1,15 +1,54 @@ | |||
| module github.com/coinbase/mongobetween | |||
|
|
|||
| go 1.13 | |||
| go 1.18 | |||
There was a problem hiding this comment.
Upgrading to 1.18 since it's the minimum required version for the latest Mongo driver; doing a go mod tidy afterwards introduced the second require block.
| @@ -302,7 +302,7 @@ func (m *Mongo) roundTrip(conn driver.Connection, req []byte, unacknowledged boo | |||
| return nil, nil | |||
| } | |||
|
|
|||
| if res, err = conn.ReadWireMessage(m.roundTripCtx, req[:0]); err != nil { | |||
| if res, err = conn.ReadWireMessage(m.roundTripCtx); err != nil { | |||
There was a problem hiding this comment.
Latest driver change will now self-create the byte array when reading the wire message: https://github.com/mongodb/mongo-go-driver/blob/v1/x/mongo/driver/topology/connection.go#L471
| func (m *mockServer) RTTMonitor() driver.RTTMonitor { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Updating tests to satisfy the latest driver.Server interface
|
Review Error for rubbal90 @ 2024-04-04 02:22:28 UTC |
There was a problem hiding this comment.
@kounat Is there a way for us to build this branch internally and test it in dev/staging before merging this into master?
|
Review Error for rubbalsidhu-cb @ 2024-04-04 02:33:15 UTC |
|
@ThatHurleyGuy yeah, we should be able to pull this branch from the Dockerfile we use to build the sidecar. I'll do that before merging this |
|
Tested this internally; it doesn't solve the |
Pulling in the latest changes to the MongoDB driver
to address.CursorNotFoundissues when migrated to Optimized Connection Strings in MongoDB AtlasTested locally running
docker-compose upandgotestsum.