feat: add connect wallet functionality to Swap component #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zizzamia
reviewed
Aug 28, 2024
| @@ -53,7 +57,7 @@ export const Wallet = ({ children }: WalletReact) => { | |||
|
|
|||
| return ( | |||
| <WalletProvider> | |||
| <WalletContent>{children}</WalletContent> | |||
| <WalletContent className={className}>{children}</WalletContent> | |||
Zizzamia
reviewed
Aug 28, 2024
src/swap/types.ts
Outdated
| @@ -121,6 +131,7 @@ export type SwapButtonReact = { | |||
| }; | |||
|
|
|||
| export type SwapContextType = { | |||
| address?: Address; | |||
There was a problem hiding this comment.
Probably we want a line of comment here explain when the address here is used.
Zizzamia
reviewed
Aug 28, 2024
| @@ -128,7 +142,17 @@ export function SwapProvider({ | |||
| destination.setLoading(true); | |||
| setLifeCycleStatus({ | |||
| statusName: 'amountChange', | |||
| statusData: null, | |||
| statusData: { | |||
| // when fetching quote, the previous | |||
Zizzamia
reviewed
Aug 28, 2024
|
|
||
| const isMissingRequiredFields = | ||
| !!statusData && | ||
| 'isMissingRequiredField' in statusData && |
Zizzamia
approved these changes
Aug 28, 2024
cpcramer
reviewed
Aug 28, 2024
| const { chainId } = useContext(AppContext); | ||
|
|
||
| console.log('base', base.id); |
Zizzamia
approved these changes
Aug 28, 2024
cpcramer
approved these changes
Aug 28, 2024
0xAlec
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Screen.Recording.2024-08-27.at.12.17.00.PM.mov
Notes to reviewers
How has it been tested?