feat: pass input text through post action #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasc
commented
Feb 29, 2024
| fid: 0, | ||
| messageHash: '0xthisisnotreal', | ||
| network: 0, | ||
| timestamp: 0, | ||
| }); | ||
| setResults((prev) => [...prev, result]); |
There was a problem hiding this comment.
we got a type error on this because postFrame may return an undefined value, and only defined values should go in the results array.
cnasc
commented
Feb 29, 2024
| fid: 0, | ||
| messageHash: '0xthisisnotreal', | ||
| network: 0, | ||
| timestamp: 0, | ||
| }); | ||
| setResults((prev) => [...prev, result]); | ||
| // TODO: handle when result is not defined |
There was a problem hiding this comment.
Probably should be an error toast or something
cnasc
commented
Feb 29, 2024
| @@ -140,7 +152,7 @@ function FrameButton({ | |||
| openModal(onConfirm); | |||
| } | |||
| // TODO: implement other actions (mint, etc.) | |||
| }, [button, setResults]); | |||
| }, [button?.action, button?.index, button?.target, inputText, openModal, setResults]); | |||
There was a problem hiding this comment.
Had a warning here because openModal wasn't included as dep. The other formatting was done automatically by IDE.
Zizzamia
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Part of #146
Passing input text value in the frame action.
Also cleaned up some lint/type errors while I was in there.
Notes to reviewers
How has it been tested?