feat: Frame now uses FrameMetadata instead of string record #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasc
commented
Mar 7, 2024
| @@ -14,40 +15,14 @@ export function Frame() { | |||
|
|
|||
| const latestFrame = results[results.length - 1]; | |||
|
|
|||
| if (!latestFrame.isValid) { | |||
There was a problem hiding this comment.
Removed this because right now it's more useful to fully render the frame even if it is not 100% correct
Zizzamia
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Following on #205, using the generated results within the
Framecomponent. For the time beingValidationResultscontinues to use the legacyRecord<string, string>tag object because it needs to be able to point to the actual tag name rather than the names fromFrameMetadata.Additionally started handling the frame state when posting back to api (part of #146).
Notes to reviewers
How has it been tested?
End-to-end against
a-frame-in-100-linesto ensure results were same as before.