-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storage] Interface Refactor + Test Cleanup #254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Pull Request Test Coverage Report for Build 12479
💛 - Coveralls |
Signed-off-by: Patrick O'Grady <prohb125@gmail.com>
patrick-ogrady
changed the title
[WIP][storage] Interface Refactor
[WIP][storage] Interface Refactor + Test Cleanup
Nov 30, 2020
patrick-ogrady
changed the title
[WIP][storage] Interface Refactor + Test Cleanup
[storage] Interface Refactor + Test Cleanup
Nov 30, 2020
patrick-ogrady
force-pushed
the
patrick/balance-storage-mocks
branch
from
November 30, 2020 17:15
4233432
to
7475d17
Compare
patrick-ogrady
requested review from
alex-stone,
arjun-io,
cindyxkuang,
qiwu7,
yfl92 and
septerr
November 30, 2020 17:25
yfl92
approved these changes
Nov 30, 2020
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to test
modules
, we've decided to refactor thestorage
package intostorage/database
andstorage/modules
. This allows us to use generatedmocks
when testingstorage/modules
(removes a circular dependency that prohibited use of interfaces defined instorage
) instead of relying on hand-rolled mocks 🤮 .This PR adds no new functionality!
Changes
storage
intodatabase
,modules
,encoder
, anderrors
mocks
for tests instead of hand-rolled mocksBalanceStorage
BroadcastStorage
CoinStorage
goimports-reviser
incheck-gen