fix: use the old icons importer for now [MDS-41] #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theycallmehero
requested changes
Apr 5, 2022
| </#CodePreview> | ||
| </:code> | ||
| </ExampleAndCode> | ||
|
|
||
| <ExampleAndCode id="currency_16" class="mt-4"> | ||
| <:example> | ||
| <IconJapaneseYen font_size="10rem" /> | ||
| <Currency name="icon_japanese_yen" font_size="10rem" /> |
There was a problem hiding this comment.
Very good job! One note / question:
Currently Moon has agremeent, that Icons are named as separate components - so if some component goes missing, client has compile time error that needs to be fixed.
Does this approach has this validation?
Maybe you can propose some solution, that would have compile time check, that if logo/currency/icon is being used, but it does not exist, then instant feedback available. (Surface syntax has prop syntax key "values: [:list, :of, :supported, :values]" but maybe there is some alternative also?
There was a problem hiding this comment.
Thanks 😁 Separate modules for icons are also generated. So they can also use that approach if compile time error detection is needed.
theycallmehero
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.