Allow ignore_marker to be a dangling symlink

[rotu]

As per ros-infrastructure/rep#256

[dirk-thomas]

Have you tried running the patch?

[codecov]

Codecov Report

Merging #344 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   80.56%   80.54%   -0.02%     
==========================================
  Files          56       56              
  Lines        3237     3239       +2     
  Branches      536      536              
==========================================
+ Hits         2608     2609       +1     
- Misses        592      593       +1     
  Partials       37       37              

Impacted Files	Coverage Δ
colcon_core/verb/build.py	0.00% <0.00%> (ø)
colcon_core/package_identification/ignore.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e3710...cfdde6b. Read the comment docs.

[rotu]

Have you tried running the patch?

I hadn't, as can be seen from CI!

[rotu]

This patch now works correctly and is ready for review

[dirk-thomas]

With the REP update merged (ros-infrastructure/rep#256) I will go ahead ad merge this.

[chapulina]

🧑‍🌾

The Appveyor build failed after this PR was merged:

https://ci.appveyor.com/project/dirk-thomas/colcon-core/history

[5.219s] ERROR    colcon.colcon_core.event_reactor:event_reactor.py:86 Exception in event handler extension 'extension3': custom exception
Traceback (most recent call last):
  File "C:\projects\colcon-core\colcon_core\event_reactor.py", line 78, in _notify_observers
    retval = observer(event)
  File "C:\projects\colcon-core\test\test_event_reactor.py", line 43, in __call__
    raise RuntimeError('custom exception')
RuntimeError: custom exception

[dirk-thomas]

@chapulina The correct error message of the test failure is:

>           assert error.call_count == 2
E           AssertionError: assert 1 == 2
E            +  where 1 = <MagicMock name='error' id='872644937432'>.call_count
test\test_event_reactor.py:80: AssertionError

I retriggered the build and expect it to pass (since it passed before).

[dirk-thomas]

@chapulina See #345 which makes the test (less | not) flaky.