Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relax timing race in event_reactor test #345

Merged
merged 4 commits into from
May 7, 2020
Merged

relax timing race in event_reactor test #345

merged 4 commits into from
May 7, 2020

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas added the bug Something isn't working label May 6, 2020
@dirk-thomas dirk-thomas self-assigned this May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020 •
edited
Loading

Codecov Report

Merging #345 into master will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   80.56%   79.31%   -1.26%     
==========================================
  Files          56       56              
  Lines        3237     3297      +60     
  Branches      536      552      +16     
==========================================
+ Hits         2608     2615       +7     
- Misses        592      645      +53     
  Partials       37       37
Impacted Files Coverage Δ
colcon_core/verb/build.py 0.00% <0.00%> (ø)
colcon_core/package_identification/ignore.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e3710...3c74b48. Read the comment docs.

@dirk-thomas dirk-thomas force-pushed the dirk-thomas/event_reactor_test_flakyness_windows branch from d2ca28e to 66f3273 Compare May 6, 2020 21:45
@dirk-thomas dirk-thomas mentioned this pull request May 6, 2020
Merged
chapulina
chapulina approved these changes May 6, 2020
View reviewed changes
Copy link

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRTM, where the R stands for reasonable. Thanks!

@dirk-thomas dirk-thomas merged commit 0c054b4 into master May 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/event_reactor_test_flakyness_windows branch May 7, 2020 03:12
@dirk-thomas dirk-thomas added this to the 0.5.10 milestone May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Milestone
0.5.10
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @chapulina