-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cell_data_set
validity checks are failing on Bioconductor 3.10
#246
Comments
Hi Mike, |
Sure I’ll work on a reprex this weekend and get back to you |
Hi @hpliner, I can confirm that I'm still seeing this issue on multiple machines, both Linux and macOS. Here's the code I'm testing: I'm running the latest version of Bioconductor 3.10, with Here's the stack trace:
Session info via
|
I am seeing the same problem, but my script was running smoothly by the end of October. The exact code is: cds <- new_cell_data_set(expression_matrix, |
Hello, |
Hi! @mjsteinbaugh @hpliner we work based on a conda setup, where re-installing monocle3 is not a practical option (because conda installs everything just once). We see the same error. Any ideas of why re-installing monocle3 fixes the issue? I'm using:
inside an R session in that conda environment I get:
Thanks! |
@pcm32 How are you managing your conda environments? With conda create --name="r-monocle3" r-monocle3
conda activate r-monocle3
R
library(monocle3) Let me know if you're still seeing the Best, |
Thanks @mjsteinbaugh, we use create as well every time to have a clean install, but the package that we install is I'll try the direct example that you suggest and report back, but I suspect there must be something going on between monocle3 and singlecellexperiment. |
@pcm32 Refer to this issue posted in the SingleCellExperiment repo: drisso/SingleCellExperiment#43 |
Each S4 class is created during package installation. As in, the definition of the class is created during installation and hard-coded into the contents of the monocle3 installation directory; in general, specific instances of the class are only created at run-time. If you install monocle3 and then update SingleCellExperiment, the damage is already done; monocle3 defined its classes using the old SCE class at install-time, so updating SCE doesn't help any more. You need to re-install monocle3 to make use of the new class definition. Normally, this would not be an issue; I take care to make sure that all downstream Bioconductor packages are happy when I change anything, so all Bioconductor packages should continue to work seamlessly. I can't be responsible for all the non-BioC packages floating around. |
Merge PR #20002, commits were: * Pins monocle3 and single cell experiment to avoid cole-trapnell-lab/monocle3#246
Hi @hpliner,
You may be aware of this already, but I'm seeing some issues with validity checks on
cell_data_set
using Bioconductor 3.10, due to changes inSingleCellExperiment
.Here's an example, following your recommended example dataset on the monocle3 website
Previously saved objects are currently failing
validObject()
checks, due to the underlying changes inSingleCellExperiment
.Best,
Mike
The text was updated successfully, but these errors were encountered: