Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive 'Debug' for LittleEndian and BigEndian #33

Closed
FanShupei opened this issue Mar 23, 2023 · 2 comments
Closed

Derive 'Debug' for LittleEndian and BigEndian #33

FanShupei opened this issue Mar 23, 2023 · 2 comments

Comments

@FanShupei
Copy link

Consider the following code snippet, rustc rejects to debug-print elf_file.ehdr because it does not implement 'Debug', caused by that LittleEndian does not implement 'Debug'. This is probably undesirable, so I suggest LittleEndian and BigEndian shall derive Debug.

let elf_file = ElfBytes::<LittleEndian>::minimal_parse(data)?;
dbg!(&elf_file.ehdr); // error
cole14 added a commit that referenced this issue May 5, 2023
@cole14
Derive Debug on LittleEndian and BigEndian
a2fa6a1 
This addresses #33
@cole14
Copy link
Owner

cole14 commented May 5, 2023

going to leave open until i make a release including the commit

cole14 added a commit that referenced this issue Jun 8, 2023
@cole14
Turn on #![deny(missing_debug_implementations)]
bee2d24 
This helps ensure we're deriving Debug, as it's generally always helpful. This helps avoid issues like #33
cole14 added a commit that referenced this issue Oct 9, 2023
@cole14
Turn on #![deny(missing_debug_implementations)]
d400742 
This helps ensure we're deriving Debug, as it's generally always helpful. This helps avoid issues like #33
@cole14
Copy link
Owner

cole14 commented Oct 9, 2023

Released as v0.7.3

@cole14 cole14 closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cole14 @FanShupei