D9 - Fix the submission of default custom field value #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I ran into this issue myself last week. Did you scan the code to check if we accidentally use ‘value’ instead of ‘default_value’ for other elements perhaps as well? |
|
yes, there are more than 10 such assignments. I think we should do a follow up PR after confirming the same issue on each of them. Hope thats fine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix the submission of default custom field value
Before
When submitting a webform which updates a custom field, the value is always set to the default value (if there is one) when "Option type" is set to "Reuse an existing set".
After
Fixed.
Technical Details
Update the
#valuewith#default_valueproperty.Comments
Drupal Ticket: https://www.drupal.org/project/webform_civicrm/issues/3326150