Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my journey in the Journey book #201

Closed
wants to merge 3 commits into from
Closed

Added my journey in the Journey book #201

wants to merge 3 commits into from

Conversation

deltaTH
Copy link

@deltaTH deltaTH commented Oct 25, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@deltaTH
Copy link
Author

deltaTH commented Oct 25, 2022

Added my journey in the journey book...
Hoping it gets merged

Copy link
Member

@vikasganiga05 vikasganiga05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deltaTH , Please make the following changes to your contribution. Thank You.

@@ -8,6 +8,7 @@
- Journeys

- [Aayushi Mittal](../journeys/Aayushi-Mittal.md)
- [Abhay Nandan Singh](../journeys/deltaTH.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Abhay Nandan Singh](../journeys/deltaTH.md)

Please don't make changes to _layouts/sidebar.md file. The gh-action will create a link to your journey on the sidebar.

@@ -0,0 +1,34 @@
<h1 align="center">Hi 👋, I'm Abhay Nandan Singh</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Abhay, The journey file is the same as your GitHub profile readme file. Can you please write more about your journey? If you want to know what exactly your journey should include please refer to What should I share in my journey?.

@deltaTH deltaTH closed this by deleting the head repository Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants