Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix formatTime for milliseconds #443

Closed
thijstriemstra opened this issue Feb 3, 2020 · 0 comments · Fixed by #474
Closed

fix formatTime for milliseconds #443

thijstriemstra opened this issue Feb 3, 2020 · 0 comments · Fixed by #474
Labels
Milestone

Comments

@thijstriemstra
Copy link
Member

thijstriemstra commented Feb 3, 2020

A duration of 179.95755102040818 with msDisplayMax option enabled results in a current time formatted as 2:59:120957:

Screenshot from 2020-02-03 00-54-42

@thijstriemstra thijstriemstra changed the title improve formatTime for milliseconds fix formatTime for milliseconds Feb 3, 2020
@thijstriemstra thijstriemstra mentioned this issue May 18, 2020
@thijstriemstra thijstriemstra added this to the 4.0 milestone May 18, 2020
thijstriemstra added a commit that referenced this issue May 19, 2020
* bump required version for video.js (7.0.5) and videojs-wavesurfer (3.2.0)

* update examples for videojs-wavesurfer 3.x

* update tests config for videojs-wavesurfer 3.x

* update changelog

* build: adjust config for copy-webpack-plugin update

* bump required version for recordrtc to 5.6.1

* fix milliseconds in formatTime (#443)

* replace msDisplayMax with displayMilliseconds option

* add exportImage

* add mime module

* fix mime-type for lamejs plugin

* doc: add multi example

* ci: disable firefox for now

* ask again for device permissions in Firefox when user cleared them manually (#468)

* audio+screen: add missing error handler

* add optional fileExtension param

* update dev dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant