-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story 9: Content rule action #45
Conversation
Pull Request Test Coverage Report for Build 237
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but Sally should approve the documentation fixes. 👍
@datakurre @Shriyanshagro I made a couple of requests for changing documentation, and one request for changing the UI (from "IFTTT applet name" to IFTTT event name). |
@Shriyanshagro Have you looked into @skleinfeldt's change requests? |
Once @skleinfeldt approves the documentation changes, this can be merged even test coverage is dropping a bit. We have more tests waiting in other pulls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge. There will be a few documentation tweaks, but this will be much easier when everything is merged and I don't have to review separate branches. If I find anything major I'll open a ticket. Whatever minor things I find I'll just fix.
Story 7: Email site content applet
#24
This includes updated documentation; updated naming convention of IFTTT Trigger; and minor fixes