Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story 9: Content rule action #45

Merged
merged 6 commits into from
Jul 10, 2018
Merged

Conversation

Shriyanshagro
Copy link
Collaborator

#24
This includes updated documentation; updated naming convention of IFTTT Trigger; and minor fixes

@coveralls
Copy link

coveralls commented Jun 15, 2018

Pull Request Test Coverage Report for Build 237

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-7.8%) to 88.824%

Totals Coverage Status
Change from base Build 158: -7.8%
Covered Lines: 151
Relevant Lines: 170

💛 - Coveralls

Copy link
Collaborator

@datakurre datakurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but Sally should approve the documentation fixes. 👍

@skleinfeldt
Copy link
Collaborator

@datakurre @Shriyanshagro I made a couple of requests for changing documentation, and one request for changing the UI (from "IFTTT applet name" to IFTTT event name).

@datakurre
Copy link
Collaborator

@Shriyanshagro Have you looked into @skleinfeldt's change requests?

@datakurre
Copy link
Collaborator

Once @skleinfeldt approves the documentation changes, this can be merged even test coverage is dropping a bit. We have more tests waiting in other pulls.

Copy link
Collaborator

@skleinfeldt skleinfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. There will be a few documentation tweaks, but this will be much easier when everything is merged and I don't have to review separate branches. If I find anything major I'll open a ticket. Whatever minor things I find I'll just fix.

@datakurre datakurre merged commit 2931ddc into master Jul 10, 2018
@datakurre datakurre deleted the story-9-content-rule-action branch July 10, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants