Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where IFTTT menu was not visible #57

Merged
merged 5 commits into from
Jul 19, 2018

Conversation

datakurre
Copy link
Collaborator

@Shriyanshagro

The first commit in this pull was the reason why your new menu was not visible. You accidentally copied also the interface that was supposed to link the menu adapters with "Plone content menu".

51c1f47

I cannot blame you on this, because this whole menu framework is very well documented (well, it is documented in "Zope 3 framework" book, but its integration with Plone not so much).

The third commit disables the current IFTTT items in action menu and creates a new action group connected to IFTTT menu. It allows us to populate IFTTT menu from actions.xml:

affe60a

The second and last commit are mostly just clean up.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 270

  • 7 of 15 (46.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.1%) to 88.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/collective/ifttt/browser/menu.py 7 15 46.67%
Files with Coverage Reduction New Missed Lines %
src/collective/ifttt/browser/menu.py 1 52.5%
Totals Coverage Status
Change from base Build 265: 1.1%
Covered Lines: 341
Relevant Lines: 387

💛 - Coveralls

@datakurre
Copy link
Collaborator Author

@Shriyanshagro You may merge this to your branch once you are familiar with the changes (this is pull request to your branch, not master).

@Shriyanshagro Shriyanshagro merged commit c39e429 into story-13-ifttt-menu Jul 19, 2018
@Shriyanshagro Shriyanshagro deleted the datakurre-story-13-ifttt-menu branch July 19, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants