Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icalendar fails parsing some RRULE based timezone definitions #303

Closed
simon-budig opened this issue Feb 13, 2020 · 2 comments
Closed

icalendar fails parsing some RRULE based timezone definitions #303

simon-budig opened this issue Feb 13, 2020 · 2 comments

Comments

@simon-budig
Copy link
Contributor

Some timezone definitions fail parsing. One example is the testcase "test_create_america_new_york" in the current testsuite, which is right now marked unittest.expectedFailure.

Underlying reason is that evaluating the RRULE in some cases is done with mixed offset-awareness, datetime.rrule can't handle that (see e.g. dateutil/dateutil#851),
I've prepared a pull request to fix this. The patch evaluates the rrule with the relevant TZOFFSETFROM from the timezone description. This avoids this problem.
simon-budig added a commit to simon-budig/icalendar that referenced this issue Feb 13, 2020
@simon-budig
Correct the handling of rrules within timezone definitions.
af4fb12 
Fix for collective#303
@simon-budig simon-budig mentioned this issue Feb 13, 2020
Merged
simon-budig added a commit to simon-budig/icalendar that referenced this issue Feb 13, 2020
@simon-budig
Correct the handling of rrules within timezone definitions.
c42e822 
Fix for collective#303
@simon-budig simon-budig mentioned this issue Feb 13, 2020
Closed
@ephase ephase mentioned this issue Apr 2, 2020
Closed
thet pushed a commit that referenced this issue Aug 24, 2020
@simon-budig @thet
Correct the handling of rrules within timezone definitions.
2a82c88 
Fix for #303
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Aug 24, 2020
@thet
[fc] Repository: icalendar
e26874e 
Branch: refs/heads/master
Date: 2020-08-24T15:27:21+02:00
Author: Simon Budig (simon-budig) <simon@budig.de>
Commit: collective/icalendar@2a82c88

Correct the handling of rrules within timezone definitions.

Fix for collective/icalendar#303

Files changed:
M CHANGES.rst
M src/icalendar/cal.py
M src/icalendar/tests/test_timezoned.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Aug 24, 2020
@thet
[fc] Repository: icalendar
ebc1f3c 
Branch: refs/heads/master
Date: 2020-08-24T15:27:21+02:00
Author: Simon Budig (simon-budig) <simon@budig.de>
Commit: collective/icalendar@2a82c88

Correct the handling of rrules within timezone definitions.

Fix for collective/icalendar#303

Files changed:
M CHANGES.rst
M src/icalendar/cal.py
M src/icalendar/tests/test_timezoned.py
@thet
Copy link
Member

thet commented Aug 24, 2020

Closed by: #304

@thet thet closed this as completed Aug 24, 2020
@mauritsvanrees
Copy link
Member

I have released 4.0.7 with the fix.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thet @mauritsvanrees @simon-budig