Allow multiple relations; #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domcleal
reviewed
Apr 20, 2017
| self.audit_comment = nil | ||
| run_callbacks(:audit) { audits.create(attrs) } if auditing_enabled | ||
| audits_associated = audit_associated_with.is_a?(Array) ? audit_associated_with : [audit_associated_with] | ||
| audits_associated.each do |audit_associated| |
There was a problem hiding this comment.
Won't this create multiple, duplicate audits, one for each associated object? Though it's more complex, I think it'd make more sense for one audit to exist per event, but to change to the schema to have multiple associations.
There was a problem hiding this comment.
Hello @domcleal.
You are probably right. I had no time to take a better look and study the audited gem. I've made this because i needed in a project of mine.
It worked but i agree with you that this is not the right way of doing it. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple relations sending them as array of hashes.