Skip rollback for failed interactor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interactors should be single-purpose. An interactor should not affect its context until it's performed successfully. This eliminates the need for cleanup on failure. Only successfully performed interactors within an organizer will be rolled back.
To accomplish organizer rollback, we store instances rather than classes in the organizer's "performed" method so that "performed" for nested organizers is still intact and available.
|
Changes Unknown when pulling 7f91024 on skip-rollback-for-failed-interactor into * on master*. |
| expect(interactor4c).not_to receive(:perform) | ||
| expect(interactor5).not_to receive(:perform) | ||
|
|
||
| expect(instance4a).to receive(:rollback).once.with(no_args).ordered |
There was a problem hiding this comment.
Do we want an explicit not to receive :rollback expectation on instance4b?
There was a problem hiding this comment.
There is no spoon instance4b.
There was a problem hiding this comment.
Maybe there should be.
|
Super! 👍 |
|
Changes Unknown when pulling d56618f on skip-rollback-for-failed-interactor into * on master*. |
|
🚦 💚 |
🙏
emilford
added a commit
that referenced
this pull request
Aug 19, 2013
…teractor Skip rollback for failed interactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #4 and also fixes a rollback bug for organizers within organizers.