Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make skip-empty the default behavior and remove option #40

Merged
merged 6 commits into from
May 28, 2024
Merged

Make skip-empty the default behavior and remove option #40

merged 6 commits into from
May 28, 2024

Commits on May 28, 2024

  1. Adjust specs for default skip-empty behavior

    @darronschall
    darronschall committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a711ee4 View commit details
    Browse the repository at this point in the history

  2. Delete custom "be empty scaffolding" matcher 

    The plugin never generates empty scaffolding anymore. As such, we no longer need our custom matcher to validate the empty scaffolding content.
    @darronschall
    darronschall committed May 28, 2024
    Configuration menu
    Copy the full SHA
    e4f8100 View commit details
    Browse the repository at this point in the history

  3. Deprecate and warn on skip-empty flag. 

    This is now the default behavior.
    @darronschall
    darronschall committed May 28, 2024
    Configuration menu
    Copy the full SHA
    dd26ed5 View commit details
    Browse the repository at this point in the history

  4. Remove skip-empty from the README.md

    @darronschall
    darronschall committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c2db72e View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.md

    @darronschall
    darronschall committed May 28, 2024
    Configuration menu
    Copy the full SHA
    707a597 View commit details
    Browse the repository at this point in the history

  6. Remove skip-empty warning; error instead. 

    Rather than a soft deprecation here over two releases, we remove recognizing the flag entirely.

The migration path is small/easy for this change (updating the command to simply remove the option), and we don't have a very large user base at the moment.
    @darronschall
    darronschall committed May 28, 2024
    Configuration menu
    Copy the full SHA
    ba15374 View commit details
    Browse the repository at this point in the history