feat: laravel 11 support #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taka-oyama
requested review from
dkkoma,
kt81,
zeriyoshi,
halnique,
ojikeii,
Uyan712 and
t-matsuno-777
kt81
approved these changes
Mar 18, 2024
| @@ -568,7 +568,7 @@ public function testInsertDatetime(): void | |||
| $qb = $conn->table($tableName); | |||
|
|
|||
| $row = $this->generateTestRow(); | |||
| $carbonMax = Carbon::maxValue(); | |||
| $carbonMax = Carbon::create(9999, 12, 31, 23, 59, 59, 'UTC'); | |||
There was a problem hiding this comment.
memo: The maxValue and minValue functions were removed when Carbon v3 was introduced.
briannesbitt/Carbon@a4726ae
Laravel 11 now allows v3 series.
https://github.com/laravel/framework/blob/11.x/composer.json#L39
halnique
requested changes
Mar 19, 2024
taka-oyama
commented
Mar 19, 2024
halnique
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199