Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an upcoming airmeet event in admin dashboard🏅 #177

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

Joyeleke
Copy link
Contributor

@Joyeleke Joyeleke commented Apr 28, 2024

Description ✏️

Closes #170

There is now an additional button under the menu button that says Sync Airmeet Event in the admin dashboard. It opens up a modal allowing the user to submit an Airmeet ID. Upon clicking submit, the Airmeet event is created in our database (and thus populated in the Member Profile) using the job function.

Tasks

  • Added modal to receive Airmeet ID from user.
Screenshot 2024-04-28 at 7 08 39 PM
  • Calls the job function to sync airmeet event to the database.

Extra Info / Questions

  • I have not ran an end to end simulation as I don't have an airmeet account.
  • Should I add an extra type check to make sure eventID is a string?

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@Joyeleke Joyeleke changed the title feat: Add an upcoming Airmeet event in Admin Dashboard🏅 feat: add an upcoming Airmeet event in Admin Dashboard🏅 Apr 29, 2024
@ramiAbdou ramiAbdou changed the title feat: add an upcoming Airmeet event in Admin Dashboard🏅 feat: add an upcoming airmeet event in admin dashboard🏅 Apr 29, 2024
Copy link
Member

@ramiAbdou ramiAbdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look great, @Joyeleke! Going to make our lives just that much easier as we prepare for Fam Fridays going forward! 🚀

}

job('event.sync', {
eventId: data.eventId,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To answer your question about checking the type of eventId, the data object is validated (see the validateForm above in which we pass our schema), so we can just use data.eventId!

});

toast(session, {
message: 'Event is being synced. Check back soon.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't happen immediately since it's a background job, so I updated the text slightly.

@ramiAbdou ramiAbdou merged commit b557eea into colorstackorg:main Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an upcoming Airmeet event in Admin Dashboard 📆
2 participants