Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Implement "colour.chromatic_adaptation" convenient definition that transforms "CIE XYZ" tristimulus values from one viewing condition to another. #124

Merged
merged 6 commits into from
Sep 9, 2014
Merged

PR: Implement "colour.chromatic_adaptation" convenient definition that transforms "CIE XYZ" tristimulus values from one viewing condition to another. #124

merged 6 commits into from
Sep 9, 2014

Conversation

KelSolaar
Copy link
Member

References #123.

@KelSolaar
Implement "colour.chromatic_adaptation" convenient definition that tr…
621236c 
…ansforms "CIE XYZ" tristimulus values from one viewing condition to another.

Closes #123.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 621236c on feature/chromatic_adaptation into bf58f87 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 8a4f683 on feature/chromatic_adaptation into bf58f87 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 85e7e03 on feature/chromatic_adaptation into bf58f87 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling b3b63e2 on feature/chromatic_adaptation into bf58f87 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling ce915a3 on feature/chromatic_adaptation into bf58f87 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling dd79cac on feature/chromatic_adaptation into bf58f87 on develop.

MichaelMauderer
MichaelMauderer reviewed Sep 9, 2014
View reviewed changes
colour/adaptation/cat.py
XYZ_wr : array_like, (3,)
Target viewing condition *CIE XYZ* colourspace whitepoint matrix.
method : unicode, optional
('XYZ Scaling', 'Von Kries', 'Bradford', 'Sharp', 'Fairchild,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nitpicking level: extreme) This slightly deviates from the numpy documentation standard for parameters that only can assume fixed values. (Curly braces and default value first in sequence)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! This one is nasty because it implies I'll have to fix all thoses in the API! :] Good catch!

@MichaelMauderer
Copy link
Member

Everything else looks fine to me.

@KelSolaar
Copy link
Member Author

Great! I will merge the PR and fix the curly braces / default value issue in the v0.3.3 branch for the whole API.

@KelSolaar KelSolaar closed this Sep 9, 2014
@KelSolaar KelSolaar reopened this Sep 9, 2014
KelSolaar added a commit that referenced this pull request Sep 9, 2014
@KelSolaar
Merge pull request #124 from colour-science/feature/chromatic_adaptation
5d72b41 
PR: Implement "colour.chromatic_adaptation" convenient definition that transforms "CIE XYZ" tristimulus values from one viewing condition to another.
@KelSolaar KelSolaar merged commit 5d72b41 into develop Sep 9, 2014
@KelSolaar KelSolaar deleted the feature/chromatic_adaptation branch September 9, 2014 19:54
@KelSolaar KelSolaar added this to the v0.3.3 milestone Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@KelSolaar @coveralls @MichaelMauderer