PR: Implement support for IHLS colourspace. #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KelSolaar
reviewed
Jun 28, 2021
colour/models/rgb/__init__.py
Outdated
| @@ -19,6 +19,7 @@ | |||
| YCbCr_to_RGB, RGB_to_YcCbcCrc, YcCbcCrc_to_RGB) | |||
| from .ycocg import RGB_to_YCoCg, YCoCg_to_RGB | |||
| from .ictcp import RGB_to_ICtCp, ICtCp_to_RGB, XYZ_to_ICtCp, ICtCp_to_XYZ | |||
| from .hanbury2002 import RGB_to_IHLS, IHLS_to_RGB | |||
There was a problem hiding this comment.
Needs to be in alphabetical order here.
colour/models/rgb/__init__.py
Outdated
| @@ -42,3 +43,5 @@ | |||
| ] | |||
| __all__ += ['RGB_to_YCoCg', 'YCoCg_to_RGB'] | |||
| __all__ += ['RGB_to_ICtCp', 'ICtCp_to_RGB', 'XYZ_to_ICtCp', 'ICtCp_to_XYZ'] | |||
| __all__ += ['RGB_to_ICtCp', 'ICtCp_to_RGB'] | |||
colour/models/rgb/__init__.py
Outdated
| @@ -42,3 +43,5 @@ | |||
| ] | |||
| __all__ += ['RGB_to_YCoCg', 'YCoCg_to_RGB'] | |||
| __all__ += ['RGB_to_ICtCp', 'ICtCp_to_RGB', 'XYZ_to_ICtCp', 'ICtCp_to_XYZ'] | |||
| __all__ += ['RGB_to_ICtCp', 'ICtCp_to_RGB'] | |||
| __all__ += ['RGB_to_IHLS', 'IHLS_to_RGB'] | |||
colour/models/rgb/hanbury2002.py
Outdated
| # -*- coding: utf-8 -*- | ||
| """ | ||
| :math:`IHLS` Colour Encoding | ||
| =============================== |
colour/models/rgb/hanbury2002.py
Outdated
| References | ||
| ---------- | ||
| - :cite: | ||
| https://www.researchgate.net/publication/243602454_A_3D-Polar_Coordinate_Colour_Representation_Suitable_for_Image_Analysis |
There was a problem hiding this comment.
- Key: Hanbury2003
- Bibliography: Hanbury, A. (2003). A 3D-Polar Coordinate Colour Representation Well Adapted to Image Analysis. In J. Bigun & T. Gustavsson (Eds.), Image Analysis (pp. 804–811). Springer Berlin Heidelberg. ISBN:978-3-540-45103-7
| Defines unit tests for :mod:`colour.models.rgb.cylindrical` module. | ||
| """ | ||
|
|
||
| from __future__ import division, unicode_literals |
|
|
||
| import numpy as np | ||
| import unittest | ||
| from itertools import permutations |
| import numpy as np | ||
| import unittest | ||
| from itertools import permutations | ||
| from colour.models.rgb.hanbury2002 import (RGB_to_IHLS, IHLS_to_RGB) |
| """ | ||
| Tests :func:`colour.models.rgb.HLS.RGB_to_HLS` definition. | ||
| """ | ||
| np.testing.assert_almost_equal( |
| RGB_to_IHLS(np.array([0.45620519, 0.03081071, 0.04091952])), | ||
| np.array([3.59979176e+02, 1.21979433e-01, -1.57572751e-01]), | ||
| decimal=7) | ||
| np.testing.assert_almost_equal( |
SGeetansh
force-pushed
the
feature/IHLS_colourspace_cherry-pick
branch
from
c8616c9
to
4952a28
Compare
|
Hey @SGeetansh, As mentioned on Slack, we can cherry-pick the last commit from this branch to hopefully finish with one: https://github.com/colour-science/colour/tree/feature/hanbury2003 |
|
Thanks @SGeetansh! |
KelSolaar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked commits from #614.