Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Support for "ICaCb" colourspace. #834

Merged
merged 8 commits into from
Aug 28, 2021
Merged

PR: Support for "ICaCb" colourspace. #834

merged 8 commits into from
Aug 28, 2021

Conversation

SGeetansh
Copy link
Contributor

@SGeetansh SGeetansh commented Jul 5, 2021 •
edited
Loading

Fixes #553.

@SGeetansh SGeetansh marked this pull request as ready for review July 12, 2021 16:16
KelSolaar
KelSolaar requested changes Aug 7, 2021
View reviewed changes
colour/models/icacb.py Outdated Show resolved Hide resolved
colour/models/icacb.py Outdated Show resolved Hide resolved
colour/models/icacb.py Outdated Show resolved Hide resolved
colour/models/icacb.py Outdated Show resolved Hide resolved
colour/models/icacb.py Outdated Show resolved Hide resolved
colour/models/icacb.py Outdated Show resolved Hide resolved
colour/models/icacb.py Outdated Show resolved Hide resolved
colour/models/icacb.py Outdated Show resolved Hide resolved
colour/models/icacb.py Show resolved Hide resolved
colour/models/icacb.py Outdated Show resolved Hide resolved
@KelSolaar
Copy link
Member

Hi @SGeetansh,

On top of the above comments, it would be great to add the following please:

Documentation

  • In docs/colour.models.rst before :math:`I_GP_GT_G` Colourspace.
  • A quick example in README.rst before IgPgTg Colourspace.
  • A quick example in docs/index.rst before IgPgTg Colourspace.

Inclusion in the Graph

  • In colour/graph/conversion.py

Examples

  • In colour/examples/models/examples_models.py

Cheers,

Thomas

KelSolaar
KelSolaar reviewed Aug 7, 2021
View reviewed changes
colour/models/icacb.py Outdated Show resolved Hide resolved
colour/models/tests/test_icacb.py Show resolved Hide resolved
colour/models/tests/test_icacb.py Show resolved Hide resolved
@SGeetansh SGeetansh changed the title PR: Support for "ICaCb" colourspace PR: Support for "ICaCb" colourspace. Aug 16, 2021
KelSolaar
KelSolaar reviewed Aug 28, 2021
View reviewed changes
colour/models/icacb.py Outdated Show resolved Hide resolved
@KelSolaar
Copy link
Member

@SGeetansh : Small patch here: https://github.com/KelSolaar/colour/commit/e38b3e706e4e3581dd4e9c7806fe84422abadac2

@KelSolaar
Copy link
Member

Thanks @SGeetansh, merging!

@KelSolaar KelSolaar merged commit e0d1b04 into colour-science:develop Aug 28, 2021
@KelSolaar KelSolaar added this to the v0.4.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KelSolaar KelSolaar KelSolaar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Implement support for "ICaCb" colourspace.
2 participants
@SGeetansh @KelSolaar