PR: Support for 'ProLab' colourspace. #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SGeetansh, Let me know when you want this one to be reviewed! |
SGeetansh
force-pushed
the
ProLab_colourspace
branch
2 times, most recently
from
4114cfc
to
3ef15f8
Compare
SGeetansh
changed the title
SGeetansh
force-pushed
the
ProLab_colourspace
branch
from
55c0979
to
e96a1a9
Compare
SGeetansh
force-pushed
the
ProLab_colourspace
branch
from
86f0fd0
to
22c8855
Compare
KelSolaar
reviewed
Oct 10, 2021
| array([ 59.846628... , 115.039635... , 20.1251035...]) | ||
| """ | ||
|
|
||
| XYZ = np.asarray(XYZ) |
There was a problem hiding this comment.
@SGeetansh : This is the reason why the unit tests are actually failing, we have a way to set precision computation on most of the API but this requires using as_float_array instead of np.array. Actually, in this specific case, we want to be able to handle domain-range scale, so we will need to use to_domain_1 and from_range_100 like with CIE Lab.
|
This PR has been superseded by #932 so I'm closing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675.