Filter /vendor/bundle by default
#331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
filter-vendor-by-default
branch
from
66dac89
to
bc114f0
Compare
|
I think making and documenting a bundler profile would make more sense |
The Rails profile filters out `/vendor/bundle`, but this is also needed for many other kinds of Ruby projects. A GitHub search illustrates how often developers need to configure this: https://github.com/search?utf8=%E2%9C%93&q=simplecov+%22add_filter*vendor%22&type=Code&ref=searchresults I can't think of any downside of having this as the default behaviour.
andyw8
force-pushed
the
filter-vendor-by-default
branch
from
bc114f0
to
fab98f9
Compare
|
@bf4 makes sense, updated based on your comment. |
sferik
force-pushed
the
master
branch
2 times, most recently
from
689480e
to
ec43ea9
Compare
| SimpleCov.profiles.define 'rails' do | ||
| load_profile 'test_frameworks' | ||
|
|
||
| add_filter '/config/' | ||
| add_filter '/db/' | ||
| add_filter '/vendor/bundle/' |
There was a problem hiding this comment.
bug! load the bundler profile as well..
There was a problem hiding this comment.
That's now done as part of the load_profile 'test_frameworks' so shouldn't be necessary to repeat?
There was a problem hiding this comment.
Correction - it's now done in the SimpleCov.configure block.
|
@colszowka @bf4 any thoughts on this? |
sferik
force-pushed
the
master
branch
9 times, most recently
from
c7c5ad5
to
4c39fa3
Compare
|
👍 Merging. |
sferik
added a commit
that referenced
this pull request
Apr 18, 2015
Filter `/vendor/bundle` by default
|
Niiiice. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rails profile filters out
/vendor/bundle, but this is also needed for many other kinds of Ruby projects.A GitHub search illustrates how often developers need to configure this:
https://github.com/search?utf8=%E2%9C%93&q=simplecov+%22add_filter*vendor%22&type=Code&ref=searchresults
I can't think of any downside of having this as the default behaviour.