Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate join function #25

Closed
GreenArrow18 opened this issue Sep 21, 2019 · 2 comments
Closed

duplicate join function #25

GreenArrow18 opened this issue Sep 21, 2019 · 2 comments

Comments

@GreenArrow18
Copy link

In client.lua:
function client:join(room_name, options, callback)
return self:create_matchmake_request('join', room_name, options or {}, callback)
end

function client:join(room_id, options, callback)
return self:create_matchmake_request('joinById', room_id, options or {}, callback)
end

The second function should be called joinById instead?

Right now, I am unable to call the join function using the room name because the 2nd function (expecting the room id) overrides the first one.

@endel endel closed this as completed in 0b7c440 Sep 21, 2019
@endel
Copy link
Member

endel commented Sep 21, 2019

Ooops, thanks again @GreenArrow18, I probably didn't pay enough attention during the migration of all clients to the new v0.11 API 😅 It's fixed!

@GreenArrow18
Copy link
Author

It works now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants