Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Scala 2.13.11 and 2.12.18 #1356

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Support Scala 2.13.11 and 2.12.18 #1356

merged 3 commits into from
Jun 12, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Jun 11, 2023

  • Update acyclic to 0.3.8

@lolgab
Support Scala 2.13.11 and 2.12.18
02575d3 
- Update acyclic to 0.3.8
@lolgab lolgab mentioned this pull request Jun 11, 2023
Closed
1 task
@LuciferYang
Copy link
Contributor

master seems already support Scala 2.12.18 and Scala 2.13.11

@lolgab
Copy link
Member Author

lolgab commented Jun 11, 2023

master seems already support Scala 2.12.18 and Scala 2.13.11

This is targeting the 2.x branch which is used by Mill 0.10.x

@lolgab lolgab marked this pull request as ready for review June 11, 2023 17:31
@lolgab lolgab requested a review from lefou June 11, 2023 17:31
@lefou lefou mentioned this pull request Jun 12, 2023
Closed
lefou
lefou approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@lefou lefou merged commit 837c3ad into com-lihaoyi:2.x Jun 12, 2023
@lefou lefou added this to the after 2.5.8 milestone Jun 12, 2023
@lolgab lolgab deleted the update-scala branch June 12, 2023 08:27
@dongjoon-hyun
Copy link

Thank you so much!

@lwronski
Copy link

lwronski commented Jun 16, 2023 •
edited
Loading

Hi @lolgab, thank you for adding support for Scala 2.13.11 and 2.12.18. Is it possible to create a new release of amm (2.5.9), which includes the bumped minor version of Scala? cc: @lefou

@lefou
Copy link
Member

lefou commented Jun 16, 2023

I think @lolgab already tagged a release, but for some reasons the version was not picked up by CI. Probably because the tag was pushed after the CI jobs ran. Let me try to re-run them. In case it's urgent, you can use version 2.5.8-2-159ff8f6 already.

@lefou lefou mentioned this pull request Sep 16, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.
5 participants
@lolgab @LuciferYang @dongjoon-hyun @lwronski @lefou