Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker.build should invalidate results when environment changes #3132

Open
lolgab opened this issue Apr 25, 2024 · 1 comment · May be fixed by #3257
Open

docker.build should invalidate results when environment changes #3132

lolgab opened this issue Apr 25, 2024 · 1 comment · May be fixed by #3257
Labels
contrib Issues related to contrib modules, which are probably maintained by someone outside mill core team

Comments

@lolgab
Copy link
Member

lolgab commented Apr 25, 2024

Docker images are built when the environment changes, since Docker depends on some environment variables.

Docker documentation here.

Mill should invalidate the docker build target when the environment changes.

@lolgab lolgab added the contrib Issues related to contrib modules, which are probably maintained by someone outside mill core team label Apr 25, 2024
@lefou
Copy link
Member

lefou commented Apr 25, 2024

Since the DockerModule already defines a envVars target, I'd argue that the current implementation assumes they are the only used env vars at play. This is probably not correct, since os-lib's os.proc is silently using all default env vars of the Java process if the propagateEnv parameter isn't set to false. So a fix should probably set it. If a user wants to depend on all actual env vars, she already can override envVars with T.input { sys.props }. Or we implement it that way by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib Issues related to contrib modules, which are probably maintained by someone outside mill core team
Projects
None yet
2 participants