Changes to make {clientserver,main,scalalib,scalajslib}.test work under Java 9 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robby-phd
changed the title
|
Sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pull request #215 enables mill to run under Java 9 and 10, it turns out more changes are needed to make
{clientserver,main,scalalib,scalajslib}.testwork under Java 9-10.Basically, creation of
URLClassLoaderhas to take into account "exported rt.jar" (see com-lihaoyi/Ammonite#761); a helper object method is added to facilitate this.Note that the following tests are disabled under Java 9 or above (require further investigations):
Tests using Scala 2.10 and 2.11 (cannot find xsbt.CompilerInterface)
Tests using ScalaJsUtil.runJs (null when retrieving nashorn script engine)
Integrating this pull request builds a mill release that can be used to run
test-mill-0.shusing oraclejdk9 in travis.