Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.7.0 #29

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Release v0.7.0 #29

merged 4 commits into from
Jan 18, 2023

Conversation

thanethomson
Copy link
Contributor

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from a team as a code owner January 17, 2023 19:42
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson mentioned this pull request Jan 17, 2023
7 tasks
@@ -0,0 +1,2 @@
- Fork tm-db and rename fork to cometbft-db
([#7](https://github.com/cometbft/cometbft-db/issues/7))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escape the number.
Optionally, use the PR instead of the issue number.

Suggested change
([#7](https://github.com/cometbft/cometbft-db/issues/7))
([\#29](https://github.com/cometbft/cometbft-db/pull/29))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The historical convention has always been to refer to issues. The only reason why most changelog issues have included references to PRs is because contributors haven't been very good at capturing the problems they're trying to solve in issues 🙂

For now the escaping doesn't affect the rendering.

Copy link
Contributor

@lasarojc lasarojc Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer issues as well, since they may refer to multiple PR that sum to fix it, but I was going by the contributing guide that states "It's also acceptable for xxx to refer to the relevant issue number, but pull-request numbers are preferred. " We need to update it then.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson merged commit 25056d0 into main Jan 18, 2023
@thanethomson thanethomson deleted the release/v0.7.0 branch January 18, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants