-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove priority mempool #281
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of v1 and renaming of v0 looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hvanz for this!
Closes #260
Note to reviewers: moving the files from
mempool/v0
tomempool
creates a dependency cyclemempool/clist_mempool_test.go -> internal/test/block.go -> state -> mempool
. That's why I moved the functionmakeBlocks
frominternal/test/block.go
toconsensus/replay_test.go
(the only place where it is used). The functionMakeVoteSet
ininternal/test/commit.go
was also creating a cycle, and it was unused, so I removed it.Tasks
mempool/v1
.Version
field fromMempoolConfig
.sender
,priority
,mempool_error
) ofResponseCheckTx
, which are related to the priority mempool.mempool/v0/*
tomempool/
.