Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove priority mempool #281

Merged
merged 17 commits into from
Feb 23, 2023
Merged

Remove priority mempool #281

merged 17 commits into from
Feb 23, 2023

Conversation

hvanz
Copy link
Member

@hvanz hvanz commented Feb 6, 2023

Closes #260

Note to reviewers: moving the files from mempool/v0 to mempool creates a dependency cycle mempool/clist_mempool_test.go -> internal/test/block.go -> state -> mempool. That's why I moved the function makeBlocks from internal/test/block.go to consensus/replay_test.go (the only place where it is used). The function MakeVoteSet in internal/test/commit.go was also creating a cycle, and it was unused, so I removed it.

Tasks

  • Remove the files in mempool/v1.
  • Remove the Version field from MempoolConfig.
  • Remove v1 cases from node.
  • Remove v1 cases from consensus and node tests.
  • Remove mempool version from manifest in node generator for e2e tests.
  • Remove last three fields (sender, priority, mempool_error) of ResponseCheckTx, which are related to the priority mempool.
  • Move mempool/v0/* to mempool/.
  • Update docs
  • Update changelog

@hvanz hvanz added the mempool label Feb 6, 2023
@hvanz hvanz self-assigned this Feb 6, 2023
spec/mempool/general.md Outdated Show resolved Hide resolved
@hvanz hvanz marked this pull request as ready for review February 9, 2023 18:25
@hvanz hvanz requested a review from a team as a code owner February 9, 2023 18:25
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale For use by stalebot label Feb 20, 2023
@lasarojc lasarojc added wip Work in progress and removed stale For use by stalebot labels Feb 20, 2023
Copy link
Contributor

@lasarojc lasarojc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of v1 and renaming of v0 looks good to me

Copy link
Contributor

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hvanz for this!

proto/tendermint/abci/types.proto Outdated Show resolved Hide resolved
config/config.go Show resolved Hide resolved
internal/test/block.go Show resolved Hide resolved
@hvanz hvanz merged commit d227550 into main Feb 23, 2023
@hvanz hvanz deleted the hernan/260-remove-priority-mempool branch February 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mempool wip Work in progress
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove priority mempool from v0.38
5 participants