Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABCI calls should crash/exit in all cases when the call itself reports and error #496

Merged
merged 3 commits into from
Mar 13, 2023
Merged

ABCI calls should crash/exit in all cases when the call itself reports and error #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d9dcf7
Review call hierarchies of ABCI methods to make sure they panic on error
sergio-mena Mar 9, 2023
6f3ff9c
Added changelog
sergio-mena Mar 10, 2023
5d29bf6
Trying 1.20.2 explicitly
sergio-mena Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/496-error-on-applyblock-should-panic.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[consensus]` Unexpected error conditions in `ApplyBlock` are non-recoverable, so ignoring the error and carrying on is a bug. We replaced a `return` that disregarded the error by a `panic`.
([\#496](https://github.com/cometbft/cometbft/pull/496))
2 changes: 1 addition & 1 deletion .github/workflows/govulncheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: "1.20"
go-version: "1.20.2"
- uses: actions/checkout@v3
- uses: technote-space/get-diff-action@v6
with:
Expand Down
3 changes: 1 addition & 2 deletions consensus/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1706,8 +1706,7 @@ func (cs *State) finalizeCommit(height int64) {
block,
)
if err != nil {
logger.Error("failed to apply block", "err", err)
return
panic(fmt.Sprintf("failed to apply block; error %v", err))
}

fail.Fail() // XXX
Expand Down
2 changes: 1 addition & 1 deletion state/execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func (blockExec *BlockExecutor) ProcessProposal(
NextValidatorsHash: block.NextValidatorsHash,
})
if err != nil {
return false, ErrInvalidBlock(err)
return false, err
}
if resp.IsStatusUnknown() {
panic(fmt.Sprintf("ProcessProposal responded with status %s", resp.Status.String()))
Expand Down