Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algorithm template - support for 2d images #289

Merged
merged 5 commits into from
Feb 18, 2020
Merged

Algorithm template - support for 2d images #289

merged 5 commits into from
Feb 18, 2020

Conversation

silvandeleemput
Copy link
Member

Closes #287

  • Algorithm template supports 2d and 3d images
  • Simplified candidates serialization
  • Made candidate selection use connected components and center of mass
  • Better input test image (lung mask with several nodules bg-0, mask-1, nodules-2)

@silvandeleemput
Added 2D image support for the algorithm template #287
ee68c9a 
* Replaced the results.json file
* Made nodule selection less prone to error
@silvandeleemput
Fixed bug with updated algorithm template #287
69c4d35
@silvandeleemput
Added tests for 2D and empty case inputs for detection algorithm #287
9974d90
@silvandeleemput
Modified test images for algorithm template and candidate detection b…
5f2633d 
…asic example #287

* Removed 1 of 2 test images and changed the other to a lung mask with several nodules
* Modified results files
* Cleaned tests
* Changed detection algorithm with connected components and center of mass functions
@silvandeleemput
Replaced algorithm template assert with active check #287
bc81b6a
@codecov
Copy link

codecov bot commented Feb 17, 2020 •
edited
Loading

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files          12       12           
  Lines         778      778           
  Branches      114      114           
=======================================
  Hits          657      657           
  Misses         82       82           
  Partials       39       39
Impacted Files Coverage Δ
evalutils/evalutils.py 81.89% <0%> (-0.83%) ⬇️
evalutils/roc.py 93.75% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00e92f...bc81b6a. Read the comment docs.

@silvandeleemput silvandeleemput mentioned this pull request Feb 17, 2020
Merged
jmsmkn
jmsmkn approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that using Lung is confusing but we can change that later.

@jmsmkn jmsmkn merged commit 51b82c2 into master Feb 18, 2020
@jmsmkn jmsmkn deleted the 287-support-for-2d-images-algorithm-template branch February 18, 2020 10:16
@silvandeleemput
Copy link
Member Author

@jmsmkn I agree, I changed this in the follow-up PR #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmsmkn jmsmkn jmsmkn approved these changes

Assignees

@jmsmkn jmsmkn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support 2D images for the algorithm template as well
2 participants
@silvandeleemput @jmsmkn