Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add average ROC function + test #296

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Add average ROC function + test #296

merged 4 commits into from
Sep 16, 2020

Conversation

Rubenkl
Copy link
Contributor

@Rubenkl Rubenkl commented Sep 2, 2020

Function to average ROC curves using vertical thresholding by fixing the FP rate.
Test also added, but unsure if these will run automatically somehow?

@keelinm

@jmsmkn
Copy link
Member

jmsmkn commented Sep 2, 2020

Thanks!

The tests are only failing on code style, could you install black==19.10b0 and run it on your changes? https://github.com/psf/black

The implementation looks good to me but @silvandeleemput would you be able to review?

Rubenkl added a commit to Rubenkl/evalutils that referenced this pull request Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #296 into master will increase coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   84.15%   84.70%   +0.55%     
==========================================
  Files          12       13       +1     
  Lines         833      863      +30     
  Branches      121      122       +1     
==========================================
+ Hits          701      731      +30     
  Misses         88       88              
  Partials       44       44              
Impacted Files Coverage Δ
evalutils/roc.py 95.19% <100.00%> (+1.44%) ⬆️
evalutils/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5c946...02cb93c. Read the comment docs.

Copy link
Member

@silvandeleemput silvandeleemput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I would recommend adding:

  • the required keyword arguments
  • a fixture for fixing the random seed

tests/test_roc.py Show resolved Hide resolved
evalutils/roc.py Show resolved Hide resolved
Copy link
Member

@silvandeleemput silvandeleemput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmsmkn jmsmkn merged commit ddf63b5 into comic:master Sep 16, 2020
@kiranvaidhya
Copy link
Contributor

I get this error when I do from evalutils.roc import average_roc_curves. Is there a bug that needs to be fixed?

image

@Rubenkl
Copy link
Contributor Author

Rubenkl commented Jan 18, 2021

I get this error when I do from evalutils.roc import average_roc_curves. Is there a bug that needs to be fixed?

image

This commit is not yet in the latest release. Try installing and/or running this command to get the function:
pip install -U git+https://github.com/comic/evalutils@master

@jmsmkn
Copy link
Member

jmsmkn commented Jan 18, 2021

Ah, you're right! Hang on I will make a new release

@jmsmkn
Copy link
Member

jmsmkn commented Jan 18, 2021

Ok, 0.2.4 released and is on pypi which includes this function, @kiranvaidhya please upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants