-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add average ROC function + test #296
Conversation
Thanks! The tests are only failing on code style, could you install The implementation looks good to me but @silvandeleemput would you be able to review? |
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 84.15% 84.70% +0.55%
==========================================
Files 12 13 +1
Lines 833 863 +30
Branches 121 122 +1
==========================================
+ Hits 701 731 +30
Misses 88 88
Partials 44 44
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, I would recommend adding:
- the required keyword arguments
- a fixture for fixing the random seed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ah, you're right! Hang on I will make a new release |
Ok, 0.2.4 released and is on pypi which includes this function, @kiranvaidhya please upgrade. |
Function to average ROC curves using vertical thresholding by fixing the FP rate.
Test also added, but unsure if these will run automatically somehow?
@keelinm