Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Annotate overridden members #177

Closed
dw2kim opened this issue Jun 24, 2020 · 8 comments
Closed

Annotate overridden members #177

dw2kim opened this issue Jun 24, 2020 · 8 comments
Labels
bug Something isn't working question Further information is requested

Comments

@dw2kim
Copy link

dw2kim commented Jun 24, 2020

Bug description
After generating the graphql.dart, there is warning:
info: Annotate overridden members. (annotate_overrides at ...)

Specs
artemis: ^7.0.0-beta.11

build.yaml:
targets:
  $default:
    builders:
      artemis:
        options:
          schema_mapping:
            - output: lib/src/service/gql/models/schema.dart
              schema: lib/src/service/gql/models/schema.graphql
              queries_glob: lib/src/service/gql/queries/**.graphql
      json_serializable:
        options:
          any_map: false
          checked: false
          create_factory: true
          create_to_json: true
          disallow_unrecognized_keys: false
          explicit_to_json: false
          field_rename: none
          ignore_unannotated: false
          include_if_null: true
          nullable: true
Artemis output:
# Please paste the output of
$ flutter pub run build_runner build --verbose
#or
$ pub run build_runner build --verbose
GraphQL schema:
@JsonSerializable(explicitToJson: true)
class AppointmentArguments extends JsonSerializable with EquatableMixin {
  AppointmentArguments({@required this.id});

  factory AppointmentArguments.fromJson(Map<String, dynamic> json) =>
      _$AppointmentArgumentsFromJson(json);

  final String id;

  @override
  List<Object> get props => [id];
**HERE: We need the Override annotation. We are putting it manually right now**
  Map<String, dynamic> toJson() => _$AppointmentArgumentsToJson(this);
}
GraphQL query:
query appointment($id: String!) {
  appointment(id: $id) {
    id
    serviceCode {
      id
      name
      icon {
        key
      }
      description
      trade {
        id
        name
        blackoutPeriod {
          id
          message
          isNonContractOnly
          days
        }
      }
    }
    serviceZone {
      id
      name
      timezone
    }
  }
}
@dw2kim dw2kim added the bug Something isn't working label Jun 24, 2020
@vasilich6107
Copy link
Collaborator

Hi.
Try latest beta.
6.4.4-beta.1

@vasilich6107
Copy link
Collaborator

@dw2kim did you have chance to try latest beta?

@vasilich6107 vasilich6107 added the question Further information is requested label Jun 27, 2020
@vasilich6107
Copy link
Collaborator

@dw2kim did you have chance to try latest beta?

@vasilich6107
Copy link
Collaborator

Closing this due to the missing response from @dw2kim
Fell free to comment and reopen

@Tahmeed27
Copy link

Hey I've got this exact same issue where after I run flutter analyze, I get the issue annotate overridden members. I'm on:
artemis: ^7.0.0-beta.11
Any ideas?

@vasilich6107
Copy link
Collaborator

If you are experiencing this issue please fill the bug report as per template

@dw2kim
Copy link
Author

dw2kim commented Jun 10, 2021

@vasilich6107 yeah, this is till happening on my ends as well.
Can we reopen this bug? I can update the details with artemis: ^7.0.0-beta.11

vasilich6107 added a commit that referenced this issue Jun 10, 2021
@vasilich6107 vasilich6107 mentioned this issue Jun 10, 2021
vasilich6107 added a commit that referenced this issue Jun 10, 2021
@vasilich6107
Copy link
Collaborator

@dw2kim @Tahmeed27 check latest beta

JulianHartl pushed a commit to SelectCode/artemis that referenced this issue Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants