Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer XMR to address after swap #252

Closed
da-kami opened this issue Mar 1, 2021 · 1 comment · Fixed by #261
Closed

Transfer XMR to address after swap #252

da-kami opened this issue Mar 1, 2021 · 1 comment · Fixed by #261
Assignees

Comments

@da-kami
Copy link
Member

da-kami commented Mar 1, 2021

  • Remove buy-xmr command
  • Move all the options of buy-xmr to the global scope
  • Add obligatory parameter --xmr-address (try to use required if command is none of structopt to avoid having to specify it for other commands)

Note (Daniel): Once we do this we will have to make sure to wait the full 10 blocks on stagenet to be able to spend from the wallet created with generate_from_keys. At the moment this is set to 5 blocks which does not make much sense - it should either be 10 or 0 - if we spend it should be 10 if don't spend it can be 0, then the user has to make sure to wait the required 10 blocks to be able to spend.

@da-kami
Copy link
Member Author

da-kami commented Mar 3, 2021

After giving this some more thought the conclusion is:

Unless we make providing the address an interactive step, the user has to specify the Monero address as part of the command. This means one cannot just start the application without providing zero parameters.

Given, that we have at least one parameter which is the address, I think it is actually more intuitive to keep the buy-xmr command and make the address a mandatory parameter on that, as in:

swap_cli buy-xmr --receive-address [xmr-address]

Besides minimalism I don't see an advantage in doing it like this:

swap_cli [xmr-address]

The assumption is, that the user will copy and paste the command provided on the homepage anyway (the homepage would provide a field where the xmr address is to be specified).

I will keep the buy-xmr command for now. If we get complaints about it I am happy to remove it :)

@bors bors bot closed this as completed in cba9f11 Mar 3, 2021
abraham-nixon added a commit to abraham-nixon/xmr-btc-swap that referenced this issue Feb 15, 2022
261: Sweep xmr funds from generated temp wallet r=da-kami a=da-kami

Fixes #252

Please review by commit :)
Did a few cleanups before actually doing the feature.

Please note the comment that influenced this solution: comit-network/xmr-btc-swap#252 (comment)



Co-authored-by: Daniel Karzel <daniel@comit.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant