Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017 Prius auto high beam missing #187

Closed
hi-hai opened this issue Feb 6, 2018 · 23 comments
Closed

2017 Prius auto high beam missing #187

hi-hai opened this issue Feb 6, 2018 · 23 comments

Comments

@hi-hai
Copy link

hi-hai commented Feb 6, 2018

After enabled OP, all other functionalities work fine, good job! However, auto high beam functionality is missed.

@mwkrieger
Copy link

I saw this on my Honda as well. Turns out, the sensor is in the rearview mirror, so of your EON is blocking that sensor, or you've removed the rearview mirror - your auto high beams won't work.

@hi-hai
Copy link
Author

hi-hai commented Feb 27, 2018

@mwkrieger I turned on rearview mirror, but auto high beam still didn't work.

@csouers
Copy link
Contributor

csouers commented Feb 27, 2018

Incorrect. The camera provides auto high beam functionality on Honda, likely on Toyota as well. The sensor on the back of the mirror is for auto-dimming rear view mirror only. If you power off the camera through giraffe, you lose auto-high beam functionality. Retaining it would require message forwarding and keeping the camera alive.

@billy2kool
Copy link

I have a 2016 Honda Accord touring and I think your right. But is there anyone working on touring.

@chandroos
Copy link

@csouers, is there a way you can retain the power to the camera? Any panda settings?

@bitshop
Copy link

bitshop commented Mar 25, 2018

Is the camera just sending something to say it sees light or doesn't? We can likely simulate AHB with a bit of modeling...

@arne182
Copy link
Contributor

arne182 commented Mar 26, 2018

I would like to work on this after I have finished with the blindspot sensors. I assume it will be similar. The same problem exists on the RAV4 Hybrid.

@mtourangeau
Copy link

Is there a way I can help? I'm not famillialr with linux that's why I didn't fix any problem yet. If you can help me setting up the debugging environment on Windows, I'll help to fix this problem. I already install Visual Studio Code but I don't know how to debug python scripts.

@arne182
Copy link
Contributor

arne182 commented May 29, 2018 via email

@mtourangeau
Copy link

Perfect. I'll do that.

@andy867
Copy link

andy867 commented May 30, 2018 via email

@mtourangeau
Copy link

I think I have what you need. Here it is:
https://community.comma.ai/cabana/?route=96515cca9b5ce486|2018-05-29--22-30-25

@mtourangeau
Copy link

I'm using eon with panda and Giraffe. But for the recording, I connected my panda to the standard odbii port, install Chiffr app on iPhone, connect the Chffr app to the wifi panda's and record my drive. Did it works?

@arne182
Copy link
Contributor

arne182 commented May 30, 2018 via email

@arne182
Copy link
Contributor

arne182 commented Oct 25, 2018

It should be working now on my branch. AHB

@hi-hai
Copy link
Author

hi-hai commented Oct 25, 2018

@arne182 Are you able to send a PR? Thanks.

@arne182
Copy link
Contributor

arne182 commented Oct 25, 2018

The fix is so easy and thanks to wocsor and otherchase I could. The fix has a caveat.
It requires a 120ohm resistor on pins 12 and 13 of your panda. Then enable message forwarding in panda firmware and remove static values for camera.

@bitshop
Copy link

bitshop commented Oct 25, 2018 via email

@arne182
Copy link
Contributor

arne182 commented Oct 26, 2018

Yes. Termination is needed. Sounds nice. For now I just have it jammed into my giraffe and the Panda forced in. It does not even look that bad.

@arne182
Copy link
Contributor

arne182 commented Oct 27, 2018

Pull request done. #411
Test and comment.

@vanillagorillaa
Copy link
Contributor

added this functionality in 0.5.6. Closing

@arne182
Copy link
Contributor

arne182 commented Dec 18, 2018

Requires 120ohm resistor but all the information is in the pull request. What is up with the massive cleanup vanillagorillaa?

mespiritu pushed a commit to mespiritu/openpilot that referenced this issue Apr 7, 2019
Add rate-based feed-forward for lateral control commaai#593
pd0wm pushed a commit that referenced this issue Oct 9, 2019
f3b573559 move generator to python3
9efff4086 2019+ New Prius Steer Angle (#189)
f3461d143 add units and a couple new signals for toyota (#188)
16033b3ff Remove non ascii characters
de162d8c2 Toyota no dsu: fix steer angle factor, it's 1% of a rad
2fb524554 Lexus CT200H seems to have the safetyParam 1 instead of 0.73
b2fde8b11 toyota time signal (#187)
6cfe0c432 Fixed brake signal unit in Bosch Honda

git-subtree-dir: opendbc
git-subtree-split: f3b573559f1619346f082554a72cebcc43da5275
jyoung8607 pushed a commit to jyoung8607/openpilot that referenced this issue Oct 10, 2019
f3b573559 move generator to python3
9efff4086 2019+ New Prius Steer Angle (commaai#189)
f3461d143 add units and a couple new signals for toyota (commaai#188)
16033b3ff Remove non ascii characters
de162d8c2 Toyota no dsu: fix steer angle factor, it's 1% of a rad
2fb524554 Lexus CT200H seems to have the safetyParam 1 instead of 0.73
b2fde8b11 toyota time signal (commaai#187)
6cfe0c432 Fixed brake signal unit in Bosch Honda

git-subtree-dir: opendbc
git-subtree-split: f3b573559f1619346f082554a72cebcc43da5275
TDIPWR pushed a commit to TDIPWR/openpilot that referenced this issue Dec 18, 2019
nworb-cire pushed a commit to opgm/openpilot that referenced this issue Aug 2, 2024
* DLP: enforce laneless when below 5 MPH or 8 KPH

* Update CHANGELOGS.md

* make this simpler

* unused
nworb-cire pushed a commit to opgm/openpilot that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants