Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HEVC logging for PC #20269

Closed
flacomalone opened this issue Mar 7, 2021 · 4 comments
Closed

Implement HEVC logging for PC #20269

flacomalone opened this issue Mar 7, 2021 · 4 comments
Labels
good first issue Feasible for new contributers PC Issues related to running openpilot on PC

Comments

@flacomalone
Copy link

Describe the bug
When I run a simulation on CARLA, I get the log video files in hevc.mkv format. When I try to open the video with VLC, only a quick visualization of the video is shown (less than half a second). Then the video stops.
How to reproduce or log data
It happens every time I run a simulation and a video/log files are created. To do this I followed the installation instructions.

Expected behavior
A creation of a correct HEVC file.

Additional context
I tried to find the problem by checking the VLC log file. It says "mkv error: cannot use the segment". Then I tried to extract the frames of the video using ffmpeg. I only could get 2 frames. However, the video file that I used is +40 Mb, which corresponds to around 20 seconds of simulation.

The bz2 log file seems to be ok.

Operating system: Ubuntu 20.04

@flacomalone flacomalone added the PC Issues related to running openpilot on PC label Mar 7, 2021
@flacomalone flacomalone changed the title HEVC log file not created correctly during CARLA simulation. HEVC log file not created correctly during CARLA simulation. Mar 7, 2021
@flacomalone flacomalone changed the title HEVC log file not created correctly during CARLA simulation. HEVC log file not created correctly during CARLA simulation. Mar 7, 2021
@haraschax haraschax added the good first issue Feasible for new contributers label Mar 8, 2021
@pd0wm
Copy link
Contributor

pd0wm commented Mar 8, 2021

HEVCs are currently encoded using OMX which I don't think has a PC version. So on the computer we store the logs as raw.

If you want to implement this you need another implementation of VideoEoncoder in selfdrive/loggerd powered by something like ffmpeg and use that on the PC.

@godoppl
Copy link
Contributor

godoppl commented Mar 28, 2021

Would implementing libde265 be a viable solution?

@pd0wm
Copy link
Contributor

pd0wm commented Mar 29, 2021

Since it's for development only I don't attach too much value to the exact backend. As long as it's not too much code and nicely abstracted in a VideoEncoder class it's fine.

@adeebshihadeh adeebshihadeh changed the title HEVC log file not created correctly during CARLA simulation. Implement HEVC logging for PC Apr 5, 2021
@adeebshihadeh
Copy link
Contributor

Closing this as there's nothing really to track here. This is more of a nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Feasible for new contributers PC Issues related to running openpilot on PC
Projects
None yet
Development

No branches or pull requests

5 participants