Add support for Lexus NX 300h 2018 #1068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are currently failing, can you investigate? |
|
@geohot fixed. The test passes. |
The function to send these values has been removed long ago and no other function is using them. So it is time to remove them.
pd0wm
reviewed
Feb 10, 2020
selfdrive/car/toyota/interface.py
Outdated
| @@ -253,6 +253,16 @@ def get_params(candidate, fingerprint=gen_empty_fingerprint(), has_relay=False, | |||
| ret.lateralTuning.pid.kpV, ret.lateralTuning.pid.kiV = [[0.3], [0.05]] | |||
| ret.lateralTuning.pid.kf = 0.00007 | |||
|
|
|||
| elif candidate == CAR.LEXUS_NXH: | |||
| stop_and_go = True | |||
| ret.safetyParam = 100 | |||
There was a problem hiding this comment.
This does not match the 73 from the STEER_TORQUE_EPS message in the DBC file. Which one is correct? If you plot it on top LKAS request they should match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on RHD Lexus NX 300h 2018.