Added pre-commit hook for reorder-python-imports. #1575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool for automatically reordering python imports. Similar to isort but uses static analysis more.
|
Sorry, I'm not a fan. This PR adds a huge number of lines, and would take a significant time to review. Don't think the style is that useful, and a commit hook for this sounds overkill. The |
|
It passes all tests. It improves code quality and makes future merges easier. |
|
I’m not a fan of the style either. It really doesn’t make merging easier. I don’t remember the last time I had a merge conflict because of import lines. |
pd0wm
added a commit
that referenced
this pull request
May 28, 2020
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!" - pd0wm, #1575 (comment) * add pylint to pre-commit and make everything pass * Remove uncommented stuff Co-authored-by: J <user@4800.lan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool for automatically reordering python imports. Similar to isort but uses static analysis more.
From https://github.com/asottile/reorder_python_imports