VW PQ: Miscellaneous longitudinal bug fixes #27803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyoung8607
changed the title
|
Testing was successful, ready for review. |
pfeiferj
pushed a commit
to pfeiferj/pfeifer-pilot-patches
that referenced
this pull request
Apr 11, 2023
* VW PQ: Miscellaneous longitudinal fixes * touch up TODO comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix three separate issues with openpilot longitudinal control on VW PQ:
Fix the instrument cluster getting "stuck" displaying the ACC screen with lead car indicator. With the fixes from VW PQ: Misc corrections in ACC_GRA_Anzeige opendbc#792 we can now correctly set the lower display priority.
Fix the engine auto start-stop inhibit signal. It was inverted.
Set the accel request valid field when enabled. Not sure how we got away without this in the past, for example on the 2018 NMS Passat I tested last year, but some older ECUs are ignoring accel requests without it.
Verification
The fixes have all been road-tested on an older NMS (USA) Passat and a European VW Sharan.
Route
Route:
e12eb71c201af95a|2023-04-05--07-26-02Additional Info
The combination of
ACA_PrioDispandACA_AnzDisplayare supposed to be used to temporarily pop the ACC page to the foreground and increase brightness when activity happens: engagement, follow distance adjustment, or a lead car comes into range. Eventually we should emulate that stock behavior. However, openpilot doesn't allow adjustment of the follow distance, and its lead car data is so low-value right now (presence only, no distance, noisy/not debounced) that it's not yet worth implementing. The driver can still switch to the ACC data screen manually if they want to see it.