ui/MapSettings: sort destinations by recent activity #29079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
ui_map_sort_by_recent
branch
from
bf4c24f
to
8f2bc11
Compare
deanlee
force-pushed
the
ui_map_sort_by_recent
branch
from
13102ff
to
1f959dd
Compare
deanlee
force-pushed
the
ui_map_sort_by_recent
branch
4 times, most recently
from
4c2278e
to
d75027c
Compare
This was referenced Jul 24, 2023
deanlee
force-pushed
the
ui_map_sort_by_recent
branch
from
d75027c
to
aa7bf43
Compare
|
thanks! |
incognitojam
added a commit
that referenced
this pull request
Aug 27, 2023
The API now includes "modified" timestamps for saved locations. This is the time the location was "last modified", and is useful for determining when the device navigated to a "recent" location. https://api.comma.ai/#retrieve-saved-locations Parse and combine this timestamp with the local "last activity" time to improve location sorting. Related: #29079 Closes: #29074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigationRequesttoNavManager. Move all params/nav related operations intoNavManager.MapSettingsis only responsible for UI stuffs. this will also reduce some IO operations.NavDestination