Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subaru: ES_Distance cruise cancel safety #29362

Merged
merged 3 commits into from Aug 14, 2023
Merged

Subaru: ES_Distance cruise cancel safety #29362

merged 3 commits into from Aug 14, 2023

Conversation

jnewb1
Copy link
Contributor

@jnewb1 jnewb1 commented Aug 12, 2023

Current cancel request method (using simulated buttons) uses the same message that contains Cruise_Throttle meaning we could have sent any throttle we wanted

depends: commaai/panda#1576

@jnewb1 jnewb1 marked this pull request as ready for review August 12, 2023 21:38
@jnewb1 jnewb1 added the subaru label Aug 13, 2023
@jnewb1 jnewb1 changed the title Subaru: cancel safety Subaru: ES_Distance cruise cancel safety Aug 13, 2023
@jnewb1 jnewb1 added the car vehicle-specific label Aug 13, 2023
@jnewb1 jnewb1 merged commit c8cae71 into master Aug 14, 2023
19 checks passed
@jnewb1 jnewb1 deleted the subaru-cancel-safety branch August 14, 2023 05:14
@jnewb1 jnewb1 added the bugfix label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix car vehicle-specific subaru
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants