Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency: remove atomicwrites package #30769

Merged
merged 12 commits into from
Dec 17, 2023
Merged

dependency: remove atomicwrites package #30769

merged 12 commits into from
Dec 17, 2023

Conversation

royjr
Copy link
Contributor

@royjr royjr commented Dec 17, 2023

may fix #30765

comma@comma-33e0a0c6:/data/openpilot$ python common/tests/test_file_helpers.py 
..
----------------------------------------------------------------------
Ran 2 tests in 0.002s

OK

adeebshihadeh
adeebshihadeh requested changes Dec 17, 2023
View reviewed changes
common/file_helpers.py Outdated Show resolved Hide resolved
common/file_helpers.py Outdated Show resolved Hide resolved
@adeebshihadeh
Copy link
Contributor

Can you rebase? There's a conflict with the poetry lockfile now.

@adeebshihadeh
Copy link
Contributor

Thanks for contributing to the dependency removal project :)

Wanna try the pycurl one?

@adeebshihadeh adeebshihadeh merged commit 7f9e41c into commaai:master Dec 17, 2023
20 of 22 checks passed
@royjr royjr deleted the remove-atomicwrites branch December 17, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[$100 bounty] Remove atomicwrites package
2 participants
@royjr @adeebshihadeh